Skip to content

Update permissions for Dns Records view #4826

@kimallen

Description

@kimallen

Issue description

When we initially started DNS Records, we set the permissions to IS_STAFF.
The Dns Records view should be allowed by/restricted to domain managers and staff managing the domain.

It should be IS_DOMAIN_MANAGER and IS_STAFF_MANAGING_DOMAIN

In a previous PR, IS_DOMAIN_MANAGER was added, but an added test was not easily fixed, so punting that to this issue since it was out of scope for the other one.

This will require testing in both as an analyst and an application user.

Acceptance criteria

  • Only domain managers and staff managing a domain can view dns records
  • This test is "unskipped" and passing: registrar.tests.test_views_domain.TestDomainPermissions.test_domain_pages_blocked_for_on_hold_and_deleted_for_dns_records

Additional context

Updates will be in the DnsRecordsView and the permissions.py
Additionally, tests and test data will need updating for tests to pass.

Links to other issues

No response

Metadata

Metadata

Assignees

Labels

Feature: 🌐 DNS hostingSet some RRs in a .gov domain's zonecarryoverCarryover from a previous sprintdevissue is for the dev team

Type

No type
No fields configured for issues without a type.

Projects

Status

👀 In review

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions