Skip to content

Svelte 5 bug preventing upgrade #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ciscoheat opened this issue Jan 30, 2024 · 4 comments
Closed

Svelte 5 bug preventing upgrade #318

ciscoheat opened this issue Jan 30, 2024 · 4 comments
Labels
bug Something isn't working confirmed Confirmed bug, will be worked upon in a near release. svelte-5 Related to Svelte 5

Comments

@ciscoheat
Copy link
Owner

The following issue prevents Superforms v2 to be fully compatible with Svelte 5: sveltejs/svelte#9947

Everything works but bind:group due to this.
@ciscoheat ciscoheat added bug Something isn't working confirmed Confirmed bug, will be worked upon in a near release. svelte-5 Related to Svelte 5 labels Jan 30, 2024
@ciscoheat
Copy link
Owner Author

ciscoheat commented Feb 1, 2024 •
edited
Loading

sveltejs/svelte#9947 has just been closed, waiting for the next release!

@ciscoheat
Copy link
Owner Author

Unfortunately it wasn't fully fixed with that, have to wait for this now: sveltejs/svelte#10379

@ciscoheat
Copy link
Owner Author

sveltejs/svelte#10379 is fixed now so it's pretty much working!
This one makes a test fail, but it's not directly related to Superforms: sveltejs/svelte#10426

@ciscoheat
Copy link
Owner Author

The test didn't initialize the props properly in the parent, so there's a workaround. Closing this now, we got Svelte 5 compatibility for v2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed Confirmed bug, will be worked upon in a near release. svelte-5 Related to Svelte 5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ciscoheat