Skip to content

Commit a35170b

Browse files
committed
Inspector: display Java class/method/field block tags when available
Closes #3576
1 parent bf8abf9 commit a35170b

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## master (unreleased)
44

5+
### Changes
6+
7+
- [#3576](https://github.com/clojure-emacs/cider/issues/3576): CIDER [Inspector](https://docs.cider.mx/cider/debugging/inspector.html): display Java class/method/field block tags (Returns/Throws/Params info) when available.
8+
59
## 1.11.1 (2023-11-11)
610

711
### Changes

cider-inspector.el

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,8 @@ instead of just its \"value\" entry."
528528
dict-or-value))
529529
(fragments (when v2
530530
(nrepl-dict-get dict-or-value "doc-fragments")))
531+
(block-tags (when v2
532+
(nrepl-dict-get dict-or-value "doc-block-tags-fragments")))
531533
(font-size (when-let* ((b (get-buffer cider-inspector-buffer))
532534
(variable 'text-scale-mode-amount)
533535
(continue (local-variable-p variable b)))
@@ -536,7 +538,7 @@ instead of just its \"value\" entry."
536538
;; Enabling cider-inspector-mode is the specific step that loses the font size.
537539
(buffer-local-value variable b))))
538540
(cider-make-popup-buffer cider-inspector-buffer 'cider-inspector-mode 'ancillary)
539-
(cider-inspector-render cider-inspector-buffer value font-size fragments))
541+
(cider-inspector-render cider-inspector-buffer value font-size fragments block-tags))
540542
(cider-popup-buffer-display cider-inspector-buffer cider-inspector-auto-select-buffer)
541543
(when cider-inspector-fill-frame (delete-other-windows))
542544
(ignore-errors (cider-inspector-next-inspectable-object 1))
@@ -555,7 +557,7 @@ instead of just its \"value\" entry."
555557
(when cider-inspector-page-location-stack
556558
(goto-char (pop cider-inspector-page-location-stack))))))
557559

558-
(defun cider-inspector-render (buffer str &optional font-size fragments)
560+
(defun cider-inspector-render (buffer str &optional font-size fragments block-tags)
559561
"Render STR in BUFFER."
560562
(with-current-buffer buffer
561563
(cider-inspector-mode)
@@ -564,20 +566,22 @@ instead of just its \"value\" entry."
564566
(let ((inhibit-read-only t))
565567
(condition-case nil
566568
(cider-inspector-render* (car (read-from-string str))
567-
fragments)
569+
fragments
570+
block-tags)
568571
(error (insert "\nInspector error for: " str))))
569572
(goto-char (point-min))))
570573

571574
(defvar cider-inspector-looking-at-java-p nil)
572575

573-
(defun cider-inspector-render* (elements &optional fragments)
576+
(defun cider-inspector-render* (elements &optional fragments block-tags)
574577
"Render ELEMENTS, and FRAGMENTS if present."
575578
(setq cider-inspector-looking-at-java-p nil)
576579
(dolist (el elements)
577580
(cider-inspector-render-el* el))
578581
(when fragments
579582
(insert "\n\n")
580-
(insert (cider--render-docstring (list "doc-fragments" fragments)))))
583+
(insert (cider--render-docstring (list "doc-fragments" fragments
584+
"doc-block-tags-fragments" block-tags)))))
581585

582586
(defconst cider--inspector-java-headers
583587
;; NOTE "--- Static fields:" "--- Instance fields:" are for objects,

0 commit comments

Comments
 (0)