Skip to content

Commit d7577e1

Browse files
committed
Add sensible category overrides for cider
This possibility was enabled by #3226 It can be seen in use in SystemCrafters/crafted-emacs#241 or https://clojurians.slack.com/archives/C0617A8PQ/p1696684010392119?thread_ts=1696618691.247989&cid=C0617A8PQ| It provides a better default experience for those using orderless or other newer styles.
1 parent 47d9a95 commit d7577e1

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@
4848

4949
### Changes
5050

51+
- Ensure that `cider` completion isn't used with completion styles that are currently unsupported (`flex` `initials` `partial-completion`, `orderless`, etc).
52+
- This restores completions for users that favor those styles - ottherwise the would see bad or no completions.
5153
- Improve support for multiple forms in the same line by replacing `beginning-of-defun` fn.
5254
- [#3390](https://github.com/clojure-emacs/cider/issues/3390): Enhance `cider-connect` to show all nREPLs available ports, instead of only Leiningen ones.
5355
- [#3408](https://github.com/clojure-emacs/cider/issues/3408): `cider-connect`: check `.nrepl-port`-like files for liveness, hiding them if they don't reflect an active port.

cider-completion.el

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,11 @@ in the buffer."
249249
cider-company-unfiltered-candidates
250250
"CIDER backend-driven completion style."))
251251

252+
;; Currently CIDER completions only work for `basic`, and not `flex` `initials` `partial-completion`, `orderless`, etc.
253+
;; So we ensure that those other styles aren't used with CIDER, otherwise one would see bad or no completions at all.
254+
;; This `add-to-list` call can be removed once we implement the other completion styles.
255+
(add-to-list 'completion-category-overrides '(cider (styles basic)))
256+
252257
(defun cider-company-enable-fuzzy-completion ()
253258
"Enable backend-driven fuzzy completion in the current buffer."
254259
(setq-local completion-styles '(cider)))

0 commit comments

Comments
 (0)