Issue/gh action macos aarch64 #3669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Could you please review the patch to add a separate flow in the CI for macOS on Apple Silicon? It fixes #3668
The macos-latest runner now targets Apple Silicon, and nix-emacs-ci supports version 28.x and above on this platform. I don't see this as an issue since I've also restored the old flow on the Intel macos 13.
By the way, as I've mentioned on other occasions, my personal opinion is that it is sufficient to only run/support the latest Emacs version on non-Unix platforms. :)
actions/runner-images#9741
purcell/nix-emacs-ci@ff5333a#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
Thanks
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)eldev lint
) which is based onelisp-lint
and includescheckdoc
, check-declare, packaging metadata, indentation, and trailing whitespace checks.