Commit e9b2a9a
committed
fix(workers-ai-provider): forward reasoning_effort and chat_template_kwargs (#501)
`modelSettings` passed to the provider were flowing through `getRunOptions()`
into the 3rd arg (options) of `binding.run(model, inputs, options)`, but
Cloudflare Workers AI's `reasoning_effort` and `chat_template_kwargs`
parameters belong on the 2nd arg (inputs). As a result they were silently
dropped, causing reasoning models (GLM-4.7-flash, Kimi K2.5/K2.6, GPT-OSS,
QwQ) to burn the entire output token budget on chain-of-thought.
- Type `reasoning_effort` and `chat_template_kwargs` directly on
`WorkersAIChatSettings`.
- In `buildRunInputs()`, pull both values from settings and from
`providerOptions["workers-ai"]` (per-call wins) and place them on the
inputs object. `reasoning_effort: null` is preserved (`!== undefined`
check) because it's the explicit "disable reasoning" signal.
- In `getRunOptions()`, strip them from `passthroughOptions` so they don't
leak into the binding's options arg or the REST URL query string.
- Wire `options.providerOptions` through `doGenerate` and `doStream` so
per-call overrides work without settings.
Adds 11 tests covering binding inputs placement, REST body placement,
null preservation, no leakage into options/query, per-call override, and
unrelated settings passthrough (no regression).
Closes #501.
Made-with: Cursor1 parent 0ba4637 commit e9b2a9a
5 files changed
Lines changed: 383 additions & 3 deletions
File tree
- .changeset
- packages/workers-ai-provider
- src
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
115 | 144 | | |
116 | 145 | | |
117 | 146 | | |
| |||
Lines changed: 36 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
126 | 135 | | |
127 | 136 | | |
128 | 137 | | |
129 | 138 | | |
130 | | - | |
| 139 | + | |
131 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
132 | 150 | | |
133 | 151 | | |
134 | 152 | | |
| |||
138 | 156 | | |
139 | 157 | | |
140 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
141 | 163 | | |
142 | 164 | | |
143 | 165 | | |
144 | 166 | | |
145 | 167 | | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
146 | 172 | | |
147 | 173 | | |
148 | 174 | | |
149 | 175 | | |
150 | 176 | | |
151 | 177 | | |
152 | 178 | | |
| 179 | + | |
| 180 | + | |
153 | 181 | | |
154 | 182 | | |
155 | 183 | | |
| |||
173 | 201 | | |
174 | 202 | | |
175 | 203 | | |
176 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
177 | 207 | | |
178 | 208 | | |
179 | 209 | | |
| |||
223 | 253 | | |
224 | 254 | | |
225 | 255 | | |
226 | | - | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
227 | 260 | | |
228 | 261 | | |
229 | 262 | | |
| |||
Lines changed: 23 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
19 | 42 | | |
20 | 43 | | |
21 | 44 | | |
| |||
0 commit comments