Skip to content

refactor(router): dedupe push/replace logic in next/router shim #4217

refactor(router): dedupe push/replace logic in next/router shim

refactor(router): dedupe push/replace logic in next/router shim #4217

Triggered via pull request May 16, 2026 17:17
Status Success
Total duration 3m 52s
Artifacts 3

ci.yml

on: pull_request
Matrix: create-next-app
Matrix: e2e
Matrix: test-integration
Vitest (integration report)
33s
Vitest (integration report)
Fit to window
Zoom out
Zoom in

Annotations

1 error and 13 notices
[app-with-src] › tests/e2e/app-with-src/dev-overlay-recovery.spec.ts:13:7 › Dev recovery boundary (no global-error.tsx) › soft-nav to a broken route still updates the URL: tests/e2e/app-with-src/dev-overlay-recovery.spec.ts#L32
1) [app-with-src] › tests/e2e/app-with-src/dev-overlay-recovery.spec.ts:13:7 › Dev recovery boundary (no global-error.tsx) › soft-nav to a broken route still updates the URL Error: expect(locator).toBeVisible() failed Locator: getByTestId('vinext-dev-error-indicator').or(getByTestId('vinext-dev-error-overlay')).first() Expected: visible Timeout: 10000ms Error: element(s) not found Call log: - Expect "toBeVisible" with timeout 10000ms - waiting for getByTestId('vinext-dev-error-indicator').or(getByTestId('vinext-dev-error-overlay')).first() 30 | const indicator = page.getByTestId("vinext-dev-error-indicator"); 31 | const dialog = page.getByTestId("vinext-dev-error-overlay"); > 32 | await expect(indicator.or(dialog).first()).toBeVisible({ timeout: 10_000 }); | ^ 33 | if ((await indicator.count()) > 0 && (await dialog.count()) === 0) { 34 | await indicator.click(); 35 | } at /home/runner/work/vinext/vinext/tests/e2e/app-with-src/dev-overlay-recovery.spec.ts:32:48
🎭 Playwright Run Summary
13 passed (6.8s)
🎭 Playwright Run Summary
7 passed (10.5s)
🎭 Playwright Run Summary
16 passed (9.0s)
🎭 Playwright Run Summary
1 passed (13.4s)
🎭 Playwright Run Summary
22 passed (12.7s)
🎭 Playwright Run Summary
17 passed (12.1s)
🎭 Playwright Run Summary
1 flaky [app-with-src] › tests/e2e/app-with-src/dev-overlay-recovery.spec.ts:13:7 › Dev recovery boundary (no global-error.tsx) › soft-nav to a broken route still updates the URL 1 passed (17.5s)
🎭 Playwright Run Summary
38 passed (12.6s)
🎭 Playwright Run Summary
38 passed (21.5s)
🎭 Playwright Run Summary
85 passed (23.0s)
🎭 Playwright Run Summary
1 passed (6.5s)
create-next-app (windows-latest)
NOTICE: windows-latest requests are being redirected to windows-2025-vs2026 by June 15, 2026
🎭 Playwright Run Summary
8 skipped 366 passed (2.2m)

Artifacts

Produced during runtime
Name Size Digest
blob-report-1 Expired
55.6 KB
sha256:923dc39003fc05df5d4ce731494cca95e7a6d1c87aa2fb8d300ed010b87a9509
blob-report-2 Expired
87.9 KB
sha256:7f9801d84754d8564840d60d639d077d312b85ba079423c3a5af1ec9eb9a7869
blob-report-3 Expired
44.7 KB
sha256:d66d7f734057712dfacabd2d4d10f8f90959d4641f6dfce4e8c4bf1e4470490f