[wrangler] Handle dynamic retry delays in workflows instances describe (#15569)

Author: RealBhupesh

.changeset/workflows-describe-dynamic-delay.md

@@ -0,0 +1,7 @@
+---
+"wrangler": patch
+---
+
+Fix `wrangler workflows instances describe` crashing on dynamic retry delays
+
+The Workflows API serializes function retry delays as `"[dynamic]"`. The describe command previously parsed that as a duration, produced an Invalid Date, and threw `RangeError: Invalid time value` before printing remaining steps. It now renders `unknown (dynamic delay)` and also tolerates attempts whose `end` timestamp is missing.

packages/wrangler/src/__tests__/workflows.test.ts

@@ -1058,6 +1058,131 @@ describe("wrangler workflows", () => {
 			expect(output.steps[0].output).toEqual({});
 			expect(std.out).not.toContain("[...output truncated]");
 		});
+
+		it("should describe a waiting step with dynamic retry delay without crashing", async ({
+			expect,
+		}) => {
+			writeWranglerConfig();
+			const mockResponse = {
+				end: null,
+				output: null,
+				params: {},
+				queued: mockQueuedDate.toISOString(),
+				start: mockStartDate.toISOString(),
+				status: "running",
+				success: null,
+				trigger: {
+					source: "unknown",
+				},
+				versionId: "14707576-2549-4848-82ed-f68f8a1b47c7",
+				steps: [
+					{
+						attempts: [
+							{
+								end: mockEndDate.toISOString(),
+								error: {
+									message: "boom",
+									name: "Error",
+								},
+								start: mockStartDate.toISOString(),
+								success: false,
+							},
+						],
+						config: {
+							retries: {
+								backoff: "constant",
+								delay: "[dynamic]",
+								limit: 3,
+							},
+							timeout: "30 seconds",
+						},
+						name: "flaky",
+						output: null,
+						start: mockStartDate.toISOString(),
+						success: null,
+						type: "step",
+					},
+				],
+			};
+
+			msw.use(
+				http.get(
+					`*/accounts/:accountId/workflows/some-workflow/instances/:instanceId`,
+					async () => {
+						return HttpResponse.json({
+							success: true,
+							errors: [],
+							messages: [],
+							result: mockResponse,
+						});
+					}
+				)
+			);
+
+			await runWrangler(`workflows instances describe some-workflow bar`);
+
+			expect(std.out).toContain("Retries At:  unknown (dynamic delay)");
+			expect(std.err).not.toContain("Invalid time value");
+		});
+
+		it("should describe a waiting step with a missing attempt end without crashing", async ({
+			expect,
+		}) => {
+			writeWranglerConfig();
+			msw.use(
+				http.get(
+					`*/accounts/:accountId/workflows/some-workflow/instances/:instanceId`,
+					async () => {
+						return HttpResponse.json({
+							success: true,
+							errors: [],
+							messages: [],
+							result: {
+								end: null,
+								output: null,
+								params: {},
+								queued: mockQueuedDate.toISOString(),
+								start: mockStartDate.toISOString(),
+								status: "running",
+								success: null,
+								trigger: { source: "unknown" },
+								versionId: "14707576-2549-4848-82ed-f68f8a1b47c7",
+								steps: [
+									{
+										attempts: [
+											{
+												end: null,
+												error: { message: "boom", name: "Error" },
+												start: mockStartDate.toISOString(),
+												success: false,
+											},
+										],
+										config: {
+											retries: {
+												backoff: "constant",
+												delay: "30 seconds",
+												limit: 3,
+											},
+											timeout: "30 seconds",
+										},
+										name: "flaky",
+										output: null,
+										start: mockStartDate.toISOString(),
+										success: null,
+										type: "step",
+									},
+								],
+							},
+						});
+					}
+				)
+			);
+
+			await runWrangler(`workflows instances describe some-workflow bar`);
+
+			expect(std.out).toContain("Retries At:  unknown");
+			expect(std.err).not.toContain("Invalid time value");
+		});
 	});
 
 	describe("instances send-event", () => {

packages/wrangler/src/workflows/commands/instances/describe.ts

@@ -1,4 +1,3 @@
-import assert from "node:assert";
 import { logRaw } from "@cloudflare/cli-shared-helpers";
 import { red, white } from "@cloudflare/cli-shared-helpers/colors";
 import {
@@ -226,19 +225,22 @@ function logStep(
 
 		if (step.success === null) {
 			const latestAttempt = step.attempts.at(-1);
-			let delay = step.config.retries.delay;
 			if (latestAttempt !== undefined && latestAttempt.success === false) {
-				assert(
-					latestAttempt.end,
-					"end date always exists in the API for completed attempts"
-				);
-				const endDate = new Date(latestAttempt.end);
-				if (typeof delay === "string") {
-					delay = ms(delay);
+				const retryDelayMs = parseRetryDelayMs(step.config.retries.delay);
+				if (latestAttempt.end == null) {
+					formattedStep["Retries At"] = "unknown";
+				} else if (retryDelayMs == null) {
+					formattedStep["Retries At"] = "unknown (dynamic delay)";
+				} else {
+					const retryDate = addMilliseconds(
+						new Date(latestAttempt.end),
+						retryDelayMs
+					);
+					if (!Number.isNaN(retryDate.getTime())) {
+						formattedStep["Retries At"] =
+							`${retryDate.toLocaleString()} (in ${formatDistanceToNowStrict(retryDate)} from now)`;
+					}
 				}
-				const retryDate = addMilliseconds(endDate, delay);
-				formattedStep["Retries At"] =
-					`${retryDate.toLocaleString()} (in ${formatDistanceToNowStrict(retryDate)} from now)`;
 			}
 		}
 	}
@@ -300,6 +302,27 @@ function logStep(
 	}
 }
 
+const DYNAMIC_RETRY_DELAY = "[dynamic]";
+
+function parseRetryDelayMs(delay: unknown): number | null {
+	if (delay === DYNAMIC_RETRY_DELAY) {
+		return null;
+	}
+
+	if (typeof delay === "number") {
+		return Number.isFinite(delay) ? delay : null;
+	}
+
+	if (typeof delay === "string") {
+		const parsed = ms(delay);
+		return typeof parsed === "number" && Number.isFinite(parsed)
+			? parsed
+			: null;
+	}
+
+	return null;
+}
+
 function getLastSuccessfulStep(logs: InstanceStatusAndLogs): string | null {
 	let lastSuccessfulStepName: string | null = null;