remote teardown logic and print ready-on message as soon as a runtime controller reloads

Author: dario-piotrowicz

packages/wrangler/src/api/startDevWorker/BaseController.ts

@@ -75,7 +75,6 @@ export abstract class Controller<
 type RuntimeControllerEventMap = ControllerEventMap & {
 	reloadStart: [ReloadStartEvent];
 	reloadComplete: [ReloadCompleteEvent];
-	teardown: [];
 };
 export abstract class RuntimeController extends Controller<RuntimeControllerEventMap> {
 	// ******************

packages/wrangler/src/api/startDevWorker/DevEnv.ts

@@ -96,20 +96,18 @@ export class DevEnv extends EventEmitter {
 	}
 
 	/**
-	 * Awaits for all the local runtime controllers to be ready, and when they are
+	 * Awaits for a runtime controllers to be ready, and when it is
 	 * it resolves a promise on the proxy controller to let it know that the
 	 * local server is now ready to handle requests
 	 */
 	private async resolveAllRuntimeControllersReady(): Promise<void> {
-		await Promise.all(
+		await Promise.race(
 			this.runtimes.map((runtime) => {
 				return new Promise<void>((resolve) => {
 					// A runtime controller is ready when it either emits the
 					// reloadComplete event (meaning that the runtime is in use and
-					// ready) or when it emits the teardown event (meaning that the
-					// runtime is not currently in use)
+					// ready)
 					runtime.once("reloadComplete", () => resolve());
-					runtime.once("teardown", () => resolve());
 				});
 			})
 		);

packages/wrangler/src/api/startDevWorker/LocalRuntimeController.ts

@@ -380,7 +380,6 @@ export class LocalRuntimeController extends RuntimeController {
 	};
 
 	#teardown = async (): Promise<void> => {
-		this.emitTeardownEvent();
 		logger.debug("LocalRuntimeController teardown beginning...");
 
 		if (this.#mf) {
@@ -422,9 +421,6 @@ export class LocalRuntimeController extends RuntimeController {
 	emitReloadCompleteEvent(data: ReloadCompleteEvent) {
 		this.emit("reloadComplete", data);
 	}
-	emitTeardownEvent() {
-		this.emit("teardown");
-	}
 }
 
 /**

packages/wrangler/src/api/startDevWorker/RemoteRuntimeController.ts

@@ -333,8 +333,6 @@ export class RemoteRuntimeController extends RuntimeController {
 	}
 
 	async teardown() {
-		this.emitTeardownEvent();
-
 		if (this.#session) {
 			logger.log(chalk.dim("⎔ Shutting down remote preview..."));
 		}
@@ -354,7 +352,4 @@ export class RemoteRuntimeController extends RuntimeController {
 	emitReloadCompleteEvent(data: ReloadCompleteEvent) {
 		this.emit("reloadComplete", data);
 	}
-	emitTeardownEvent() {
-		this.emit("teardown");
-	}
 }