Fix wrangler deploy erroring when it pulls down remote configs of workers containing an assets binding (#11339)

* Fix `wrangler deploy` erroring when it pulls down remote configs of workers containing an assets binding

* Ensure that extra assets values are not being shown in the wrangler deploy remote diff

Author: dario-piotrowicz

.changeset/full-ends-sell.md

@@ -0,0 +1,15 @@
+---
+"@cloudflare/workers-utils": patch
+---
+
+Fix `mapWorkerMetadataBindings` and `constructWranglerConfig` incorrectly throwing an error when encountering assets bindings
+
+Currently `mapWorkerMetadataBindings` and `constructWranglerConfig` when provided data containing an assets binding throw the
+following error:
+
+```
+ the error "`wrangler init --from-dash` is not yet supported for Workers with Assets"
+```
+
+This is incorrect and `wrangler init` specific, the changes here make sure that such error is not thrown and that the assets
+binding is instead handled

.changeset/soft-friends-obey.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix `wrangler deploy` erroring when it pulls down remote configs of workers containing an assets binding

packages/workers-utils/src/map-worker-metadata-bindings.ts

@@ -1,5 +1,4 @@
 import { assertNever } from "./assert-never";
-import { FatalError } from "./errors";
 import type { RawConfig } from "./config";
 import type { WorkerMetadataBinding } from "./types";
 
@@ -282,9 +281,13 @@ export function mapWorkerMetadataBindings(
 						];
 						break;
 					case "assets":
-						throw new FatalError(
-							"`wrangler init --from-dash` is not yet supported for Workers with Assets"
-						);
+						configObj.assets = {
+							binding: binding.name,
+							// Note: we currently don't get all the assets information from the
+							//      API, so here we are only able to set the name of the binding
+							//      hopefully in the future we can properly fully support the binding
+						};
+						break;
 					case "inherit":
 						configObj.unsafe = {
 							bindings: [...(configObj.unsafe?.bindings ?? []), binding],

packages/wrangler/src/__tests__/deploy.test.ts

@@ -15310,6 +15310,10 @@ export default{
 	it("in non-intractive (and non-strict) mode, should present a diff when there are differences between the local config and the dash config, and proceed with the deployment", async () => {
 		setIsTTY(false);
 
+		fs.mkdirSync("./public");
+
+		await mockAUSRequest([]);
+
 		writeWorkerSource();
 		mockGetServiceByName("test-name", "production", "dash");
 		writeWranglerConfig(
@@ -15321,6 +15325,12 @@ export default{
 				vars: {
 					MY_VAR: "this is a toml file",
 				},
+				assets: {
+					binding: "ASSETS",
+					// Note: remotely we only get the assets' binding name, so in the diff below you can see that
+					//       no diff for the directory configuration is shown
+					directory: "public",
+				},
 				observability: {
 					enabled: true,
 				},
@@ -15357,20 +15367,23 @@ export default{
 		//       to be able to show toml content/diffs, that combined with the fact that json(c) config files are the
 		//       recommended ones moving forward makes this small shortcoming of the config diffing acceptable
 		expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`
-				"▲ [WARNING] The local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:
+			"▲ [WARNING] The local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:
 
-				   {
-				     vars: {
-				  -    MY_VAR: \\"abc\\"
-				  +    MY_VAR: \\"this is a toml file\\"
-				     }
-				   }
+			   {
+			  +  assets: {
+			  +    binding: \\"ASSETS\\"
+			  +  }
+			     vars: {
+			  -    MY_VAR: \\"abc\\"
+			  +    MY_VAR: \\"this is a toml file\\"
+			     }
+			   }
 
 
-				  Deploying the Worker will override the remote configuration with your local one.
+			  Deploying the Worker will override the remote configuration with your local one.
 
-				"
-			`);
+			"
+		`);
 
 		expect(std.out).toMatchInlineSnapshot(`
 			"
@@ -15382,6 +15395,7 @@ export default{
 			Worker Startup Time: 100 ms
 			Your Worker has access to the following bindings:
 			Binding                                 Resource
+			env.ASSETS                              Assets
 			env.MY_VAR (\\"this is a toml file\\")      Environment Variable
 
 			Uploaded test-name (TIMINGS)

packages/wrangler/src/__tests__/deploy/get-remote-config-diff.test.ts

@@ -480,6 +480,47 @@ describe("getRemoteConfigsDiff", () => {
 		expect(diff).toBeNull();
 	});
 
+	it("should ignore all fields from an assets binding besides the binding name (since remotely only that information is stored)", () => {
+		const { diff, nonDestructive } = getRemoteConfigDiff(
+			{
+				name: "my-worker-id",
+				main: "/tmp/src/index.js",
+				workers_dev: true,
+				preview_urls: false,
+				compatibility_date: "2025-07-08",
+				account_id: "account-id-123",
+				assets: {
+					binding: "ASSETS",
+				},
+			},
+			{
+				name: "my-worker-id",
+				main: "/tmp/src/index.js",
+				workers_dev: true,
+				preview_urls: false,
+				compatibility_date: "2025-07-08",
+				account_id: "account-id-123",
+				assets: {
+					binding: "MY_ASSETS",
+					// Note: The directory and html_handling fields are ignored
+					directory: "public",
+					html_handling: "drop-trailing-slash",
+				},
+			} as unknown as Config
+		);
+		assert(diff);
+		expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
+			" {
+			   assets: {
+			-    binding: \\"ASSETS\\"
+			+    binding: \\"MY_ASSETS\\"
+			   }
+			 }
+			"
+		`);
+		expect(nonDestructive).toBe(false);
+	});
+
 	// The Observability field in the remote configuration has some specific behaviors, for that we have
 	// the following tests to make double sure to get these various observability cases right
 	// (note: this is however a best effort diffing since we cannot really perform a full one since we loose

packages/wrangler/src/deploy/config-diffs.ts

@@ -76,6 +76,14 @@ function normalizeLocalResolvedConfigAsRemote(
 
 	removeRemoteConfigFieldFromBindings(normalizedConfig);
 
+	// Currently remotely we only get the assets' binding name, so we need remove
+	// everything else, if present, from the local one
+	if (normalizedConfig.assets) {
+		normalizedConfig.assets = {
+			binding: normalizedConfig.assets.binding,
+		};
+	}
+
 	return normalizedConfig;
 }
 
@@ -250,9 +258,15 @@ function normalizeRemoteConfigAsResolvedLocal(
 	// in this way we can make sure that local-only configurations are not shown as
 	// differences between local and remote configs
 	Object.entries(localResolvedConfig).forEach(([key, value]) => {
-		// We want to skip observability since it has a remote default behavior
-		// different from that of wrangler
-		if (key !== "observability") {
+		if (
+			// We want to skip observability since it has a remote default behavior
+			// different from that of wrangler
+			key !== "observability" &&
+			// We want to skip assets since it is a special case, the issue being that
+			// remotely assets configs only include at most the binding name and we
+			// already address that in the local config normalization already
+			key !== "assets"
+		) {
 			(normalizedRemote as unknown as Record<string, unknown>)[key] = value;
 		}
 	});

packages/wrangler/src/init.ts

@@ -1,6 +1,6 @@
 import { mkdir, writeFile } from "node:fs/promises";
 import path, { dirname } from "node:path";
-import { UserError } from "@cloudflare/workers-utils";
+import { FatalError, UserError } from "@cloudflare/workers-utils";
 import { execa } from "execa";
 import { fetchResult } from "./cfetch";
 import { fetchWorkerDefinitionFromDash } from "./cfetch/internal";
@@ -164,6 +164,12 @@ export async function downloadWorker(accountId: string, workerName: string) {
 		accountId
 	);
 
+	if (config.assets) {
+		throw new FatalError(
+			"`wrangler init --from-dash` is not yet supported for Workers with Assets"
+		);
+	}
+
 	return {
 		modules,
 		config,