Use consistent spacing and ()

Author: aramprice

src/bosh-director-core/lib/bosh/director/core/templates/template_blob_cache.rb

@@ -1,7 +1,7 @@
 module Bosh::Director::Core::Templates
   class TemplateBlobCache
     def self.with_fresh_cache
-      cache = new()
+      cache = new
       yield cache
     ensure
       cache.clean_cache!

src/bosh-director/lib/bosh/director/deployment_plan/network_parser/name_servers_parser.rb

@@ -5,7 +5,7 @@ class NameServersParser
 
         include ValidationHelper
 
-        def initialize()
+        def initialize
           dns_config = Config.dns || {}
           @include_power_dns_server_addr = !!Config.dns_db
           @default_server = dns_config['server']

src/bosh-director/lib/bosh/director/manifest/manifest.rb

@@ -16,7 +16,7 @@ def self.load_from_hash(manifest_hash, manifest_text, cloud_configs, runtime_con
       load_manifest(manifest_hash, manifest_text, consolidated_cloud_config, consolidated_runtime_config, options)
     end
 
-    def self.generate_empty_manifest()
+    def self.generate_empty_manifest
       consolidated_runtime_config = Bosh::Director::RuntimeConfig::RuntimeConfigsConsolidator.new([])
       load_manifest({}, '{}', nil, consolidated_runtime_config, resolve_interpolation: false)
     end

src/bosh-director/spec/unit/api/controllers/deployments_controller_spec.rb

@@ -312,7 +312,7 @@ def manifest_with_errand(deployment_name='errand')
             it 'does not skip draining' do
               expect_any_instance_of(DeploymentManager)
                 .to receive(:create_deployment)
-                .with(anything(), anything(), anything(), anything(), anything(), hash_excluding('skip_drain'), anything())
+                .with(anything, anything, anything, anything, anything, hash_excluding('skip_drain'), anything)
                 .and_return(OpenStruct.new(:id => 1))
               post '/', spec_asset('test_conf.yaml'), { 'CONTENT_TYPE' => 'text/yaml' }
               expect(last_response).to be_redirect
@@ -323,7 +323,7 @@ def manifest_with_errand(deployment_name='errand')
             it 'skips draining' do
               expect_any_instance_of(DeploymentManager)
                 .to receive(:create_deployment)
-                .with(anything(), anything(), anything(), anything(), anything(), hash_including('skip_drain' => '*'),  anything())
+                .with(anything, anything, anything, anything, anything, hash_including('skip_drain' => '*'), anything)
                 .and_return(OpenStruct.new(:id => 1))
               post '/?skip_drain=*', spec_asset('test_conf.yaml'), { 'CONTENT_TYPE' => 'text/yaml' }
               expect(last_response).to be_redirect
@@ -334,7 +334,7 @@ def manifest_with_errand(deployment_name='errand')
             it 'skips draining' do
               expect_any_instance_of(DeploymentManager)
                 .to receive(:create_deployment)
-                .with(anything(), anything(), anything(), anything(), anything(), hash_including('skip_drain' => 'job_one,job_two'), anything())
+                .with(anything, anything, anything, anything, anything, hash_including('skip_drain' => 'job_one,job_two'), anything)
                 .and_return(OpenStruct.new(:id => 1))
               post '/?skip_drain=job_one,job_two', spec_asset('test_conf.yaml'), { 'CONTENT_TYPE' => 'text/yaml' }
               expect(last_response).to be_redirect
@@ -345,7 +345,7 @@ def manifest_with_errand(deployment_name='errand')
             it 'passes the parameter' do
               expect_any_instance_of(DeploymentManager)
                 .to receive(:create_deployment)
-                .with(anything(), anything(), anything(), anything(), anything(), hash_including('fix' => true), anything())
+                .with(anything, anything, anything, anything, anything, hash_including('fix' => true), anything)
                 .and_return(OpenStruct.new(:id => 1))
               post '/?fix=true', spec_asset('test_conf.yaml'), {'CONTENT_TYPE' => 'text/yaml'}
               expect(last_response).to be_redirect
@@ -396,7 +396,7 @@ def manifest_with_errand(deployment_name='errand')
             it 'calls create deployment with deployment name' do
               expect_any_instance_of(DeploymentManager)
                   .to receive(:create_deployment)
-                          .with(anything(), anything(), anything(), anything(), deployment, hash_excluding('skip_drain'), anything())
+                          .with(anything, anything, anything, anything, deployment, hash_excluding('skip_drain'), anything)
                           .and_return(OpenStruct.new(:id => 1))
               post '/', spec_asset('test_manifest.yml'), { 'CONTENT_TYPE' => 'text/yaml' }
               expect(last_response).to be_redirect
@@ -407,15 +407,15 @@ def manifest_with_errand(deployment_name='errand')
             it 'to false' do
               expect_any_instance_of(DeploymentManager)
                   .to receive(:create_deployment)
-                          .with(anything(), anything(), anything(), anything(), deployment, hash_including('new' => false), anything())
+                          .with(anything, anything, anything, anything, deployment, hash_including('new' => false), anything)
                           .and_return(OpenStruct.new(:id => 1))
               post '/', spec_asset('test_manifest.yml'), { 'CONTENT_TYPE' => 'text/yaml' }
             end
 
             it 'to true' do
               expect_any_instance_of(DeploymentManager)
                   .to receive(:create_deployment)
-                          .with(anything(), anything(), anything(), anything(), anything(), hash_including('new' => true), anything())
+                          .with(anything, anything, anything, anything, anything, hash_including('new' => true), anything)
                           .and_return(OpenStruct.new(:id => 1))
                Models::Deployment.first.delete
               post '/', spec_asset('test_manifest.yml'), { 'CONTENT_TYPE' => 'text/yaml' }
@@ -426,7 +426,7 @@ def manifest_with_errand(deployment_name='errand')
             it 'passes the parameter' do
               expect_any_instance_of(DeploymentManager)
                 .to receive(:create_deployment)
-                      .with(anything(), anything(), anything(), anything(), anything(), hash_including('force_latest_variables' => true), anything())
+                      .with(anything, anything, anything, anything, anything, hash_including('force_latest_variables' => true), anything)
                       .and_return(OpenStruct.new(:id => 1))
               post '/?force_latest_variables=true', spec_asset('test_conf.yaml'), {'CONTENT_TYPE' => 'text/yaml'}
               expect(last_response).to be_redirect

src/bosh-director/spec/unit/blobstore_client/azurestoragecli_blobstore_client_spec.rb

@@ -67,7 +67,7 @@ module Bosh::Blobstore
       context 'when azure_storage_cli_config_path option is provided' do
         let(:azure_storage_cli_config_path) { Dir.tmpdir }
         let(:config_file_options) do
-          options.merge (
+          options.merge(
               {
                 azure_storage_cli_config_path: azure_storage_cli_config_path,
               })

src/bosh-director/spec/unit/blobstore_client/base_spec.rb

@@ -246,7 +246,7 @@ def redacted_credential_properties_list
           expect(logger).to receive(:debug).with("[blobstore] creating 'id' start: #{start_time}").ordered
           expect(subject).to receive(:create_file).ordered
           expect(logger).to receive(:debug).with("[blobstore] creating 'id' (took #{end_time - start_time})").ordered
-          subject.create(File.new(Tempfile.new().path, 'r'), 'id')
+          subject.create(File.new(Tempfile.new.path, 'r'), 'id')
         end
       end
 

src/bosh-director/spec/unit/blobstore_client/gcscli_blobstore_client_spec.rb

@@ -70,7 +70,7 @@ module Bosh::Blobstore
       context 'when gcscli_config_path option is provided' do
         let(:gcscli_config_path) { Dir::tmpdir }
         let(:config_file_options) do
-          options.merge (
+          options.merge(
               {
                   gcscli_config_path: gcscli_config_path
               })

src/bosh-director/spec/unit/blobstore_client/s3cli_blobstore_client_spec.rb

@@ -98,7 +98,7 @@ module Bosh::Blobstore
       context 'when s3cli_config_path option is provided' do
         let(:s3cli_config_path) { Dir.tmpdir }
         let(:config_file_options) do
-          options.merge (
+          options.merge(
               {
                 s3cli_config_path: s3cli_config_path,
               })

src/bosh-director/spec/unit/deployment_plan/network_parser/name_servers_parser_spec.rb

@@ -3,7 +3,7 @@
 module Bosh::Director
   module DeploymentPlan::NetworkParser
     describe NameServersParser do
-      subject(:name_servers_parser) { NameServersParser.new() }
+      subject(:name_servers_parser) { NameServersParser.new }
 
       it 'should return nil when there are no DNS servers' do
         expect(name_servers_parser.parse('network', {})).to be_nil

src/bosh-director/spec/unit/jobs/helpers/package_deleter_spec.rb

@@ -8,8 +8,8 @@ module Jobs::Helpers
       let(:compiled_package_deleter) { CompiledPackageDeleter.new(blobstore, logger) }
       let(:blobstore) { instance_double(Bosh::Blobstore::BaseClient) }
       before { allow(blobstore).to receive(:delete) }
-      let(:release_version_1) { Models::ReleaseVersion.make() }
-      let(:release_version_2) { Models::ReleaseVersion.make() }
+      let(:release_version_1) { Models::ReleaseVersion.make }
+      let(:release_version_2) { Models::ReleaseVersion.make }
       let(:package) { Models::Package.make(blobstore_id: 'package_blobstore_id') }
 
       before do