contentsページをrenderする前にtemplateファイルが在るか無いか確認する

Author: ne-sachirou

app/controllers/contents_controller.rb

@@ -11,7 +11,7 @@ def index
 
   def discussion
     @conference = Conference.find_by(abbr: params[:event])
-    render("#{@conference.abbr}_discussion".to_sym)
+    render_if_template_exists("#{@conference.abbr}_discussion")
   end
 
   def kontest
@@ -20,12 +20,12 @@ def kontest
 
   def hands_on
     @conference = Conference.find_by(abbr: params[:event])
-    render("#{@conference.abbr}_hands_on".to_sym)
+    render_if_template_exists("#{@conference.abbr}_hands_on")
   end
 
   def job_board
     @conference = Conference.find_by(abbr: params[:event])
-    render("#{@conference.abbr}_job_board".to_sym)
+    render_if_template_exists("#{@conference.abbr}_job_board")
   end
 
   def o11y
@@ -35,16 +35,24 @@ def o11y
 
   def community_lt
     @conference = Conference.find_by(abbr: params[:event])
-    render("contents/#{@conference.abbr}/community_lt")
+    render_if_template_exists("contents/#{@conference.abbr}/community_lt")
   end
 
   def yurucafe
     @conference = Conference.find_by(abbr: params[:event])
-    render("contents/#{@conference.abbr}/yurucafe")
+    render_if_template_exists("contents/#{@conference.abbr}/yurucafe")
   end
 
   def stamprally
     @conference = Conference.find_by(abbr: params[:event])
-    render("contents/#{@conference.abbr}/stamprally")
+    render_if_template_exists("contents/#{@conference.abbr}/stamprally")
+  end
+
+  private
+
+  def render_if_template_exists(template)
+    raise NotFound unless lookup_context.template_exists?(template, [], false)
+
+    render(template)
   end
 end

spec/requests/contents_spec.rb

@@ -94,4 +94,30 @@
       end
     end
   end
+
+  describe 'GET missing content pages' do
+    before do
+      create(:cndt2020)
+    end
+
+    it 'returns 404 for hands-on without a template' do
+      get '/cndt2020/hands-on'
+      expect(response).to(have_http_status('404'))
+    end
+
+    it 'returns 404 for community_lt without a template' do
+      get '/cndt2020/community_lt'
+      expect(response).to(have_http_status('404'))
+    end
+
+    it 'returns 404 for yurucafe without a template' do
+      get '/cndt2020/yurucafe'
+      expect(response).to(have_http_status('404'))
+    end
+
+    it 'returns 404 for stamprally without a template' do
+      get '/cndt2020/stamprally'
+      expect(response).to(have_http_status('404'))
+    end
+  end
 end