Merge pull request #8 from clue-labs/tests

Improve test suite

Author: clue

src/Io/Parser.php

@@ -41,14 +41,7 @@ public function parseLogRevisions(SimpleXMLElement $xml)
             }
 
             // href contains r1 and r2 as query parameters
-            $href = (string)$anchor['href'];
-            $pos = strpos($href, '?');
-            if ($pos === false) {
-                continue;
-            }
-
-            $args = array();
-            parse_str(substr($href, $pos + 1), $args);
+            $args = $this->linkParameters((string)$anchor['href']);
 
             // all links containing r2 are links to previous revision
             if (isset($args['r2'])) {
@@ -58,4 +51,16 @@ public function parseLogRevisions(SimpleXMLElement $xml)
 
         return $revisions;
     }
+
+    private function linkParameters($href)
+    {
+        $args = array();
+        $pos = strpos($href, '?');
+
+        if ($pos !== false) {
+            parse_str(substr($href, $pos + 1), $args);
+        }
+
+        return $args;
+    }
 }

tests/ClientTest.php

@@ -57,4 +57,22 @@ public function testFetchFileRevision()
 
         $this->expectPromiseReject($promise);
     }
+
+    public function testFetchDirectoryRevision()
+    {
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/directory/?pathrev=1.0'))->will($this->returnValue($this->createPromiseRejected()));
+
+        $promise = $this->client->fetchDirectory('/directory/', '1.0');
+
+        $this->expectPromiseReject($promise);
+    }
+
+    public function testFetchPatch()
+    {
+        $this->browser->expects($this->once())->method('get')->with($this->equalTo('http://viewvc.example.org/README.md?view=patch&r1=1.0&r2=1.1'))->will($this->returnValue($this->createPromiseRejected()));
+
+        $promise = $this->client->fetchPatch('/README.md', '1.0', '1.1');
+
+        $this->expectPromiseReject($promise);
+    }
 }