Skip to content

deps: update spf13/cobra #63838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
knz opened this issue Apr 19, 2021 · 0 comments · Fixed by #63839
Closed

deps: update spf13/cobra #63838

knz opened this issue Apr 19, 2021 · 0 comments · Fixed by #63839
Labels
A-cli-flags Pertains to CLI flag handling common to all CLI commands C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented Apr 19, 2021

We have never updated cobra since the original release 0.0.5.

When upgrading the dependency, we need to be careful to not let the new cobra (since 0.0.7) auto-generate a short alias -v for --version, as we want to keep this flag reserved for use as shorthand for --verbose.
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cli-flags Pertains to CLI flag handling common to all CLI commands labels Apr 19, 2021
@knz knz mentioned this issue Apr 19, 2021
Merged
@craig craig bot closed this as completed in 0609f89 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli-flags Pertains to CLI flag handling common to all CLI commands C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: bump the cobra dependency and add autocompletion for fish knz/cockroach
1 participant
@knz