[Issue-46] extract ternary operators to local variables

Mark Pospesel · mpospese · commit 271bcdd84ca7 · 2023-03-20T18:25:39.000+01:00
diff --git a/Sources/YCoreUI/Extensions/UIKit/UIColor+rgbValue.swift b/Sources/YCoreUI/Extensions/UIKit/UIColor+rgbValue.swift
@@ -34,15 +34,17 @@ public extension UIColor {
         let g = Int(round(comp.green * 255))
         let b = Int(round(comp.blue * 255))
         let isRGB = (r >= 0 && r <= 255) && (g >= 0 && g <= 255) && (b >= 0 && b <= 255)
+        let prefix = prefix ?? ""
         let value = String(
             format: format,
             min(max(r, 0), 255),
             min(max(g, 0), 255),
             min(max(b, 0), 255)
         )
+        let suffix = (isDebug && !isRGB) ? "⚠️" : ""
         if !isRGB && YCoreUI.isLoggingEnabled {
             YCoreUI.colorLogger.warning("Color \(self) falls outside of the sRGB color space.")
         }
-        return "\(prefix ?? "")\(value)\(isDebug && !isRGB ? "⚠️" : "")"
+        return "\(prefix)\(value)\(suffix)"
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -34,15 +34,17 @@ public extension UIColor {`
`34`	`34`	`let g = Int(round(comp.green * 255))`
`35`	`35`	`let b = Int(round(comp.blue * 255))`
`36`	`36`	`let isRGB = (r >= 0 && r <= 255) && (g >= 0 && g <= 255) && (b >= 0 && b <= 255)`
	`37`	`+ let prefix = prefix ?? ""`
`37`	`38`	`let value = String(`
`38`	`39`	`format: format,`
`39`	`40`	`min(max(r, 0), 255),`
`40`	`41`	`min(max(g, 0), 255),`
`41`	`42`	`min(max(b, 0), 255)`
`42`	`43`	`)`
	`44`	`+ let suffix = (isDebug && !isRGB) ? "⚠️" : ""`
`43`	`45`	`if !isRGB && YCoreUI.isLoggingEnabled {`
`44`	`46`	`YCoreUI.colorLogger.warning("Color \(self) falls outside of the sRGB color space.")`
`45`	`47`	`}`
`46`		`- return "\(prefix ?? "")\(value)\(isDebug && !isRGB ? "⚠️" : "")"`
	`48`	`+ return "\(prefix)\(value)\(suffix)"`
`47`	`49`	`}`
`48`	`50`	`}`