Merge pull request #438 from HolyOne/master

codebude · web-flow · commit ee3a6e7add41 · 2024-04-19T22:32:09.000+02:00
Performance update on GenerateQrCode function
diff --git a/QRCoder/QRCodeGenerator.cs b/QRCoder/QRCodeGenerator.cs
@@ -172,11 +172,15 @@ public static QRCodeData GenerateQrCode(byte[] binaryData, ECCLevel eccLevel)
             string modeIndicator = DecToBin((int)EncodingMode.Byte, 4);
             string countIndicator = DecToBin(binaryData.Length, GetCountIndicatorLength(version, EncodingMode.Byte));
 
-            string bitString = modeIndicator + countIndicator;
+            StringBuilder sb = new StringBuilder();
+            sb.Append(modeIndicator).Append(countIndicator);
             foreach (byte b in binaryData)
             {
-                bitString += DecToBin(b, 8);
+                sb.Append(DecToBin(b, 8));
+
             }
+            string bitString = sb.ToString();
+
 
             return GenerateQrCode(bitString, eccLevel, version);
         }

Original file line number	Diff line number	Diff line change
`@@ -172,11 +172,15 @@ public static QRCodeData GenerateQrCode(byte[] binaryData, ECCLevel eccLevel)`
`172`	`172`	`string modeIndicator = DecToBin((int)EncodingMode.Byte, 4);`
`173`	`173`	`string countIndicator = DecToBin(binaryData.Length, GetCountIndicatorLength(version, EncodingMode.Byte));`
`174`	`174`
`175`		`- string bitString = modeIndicator + countIndicator;`
	`175`	`+ StringBuilder sb = new StringBuilder();`
	`176`	`+ sb.Append(modeIndicator).Append(countIndicator);`
`176`	`177`	`foreach (byte b in binaryData)`
`177`	`178`	`{`
`178`		`- bitString += DecToBin(b, 8);`
	`179`	`+ sb.Append(DecToBin(b, 8));`
	`180`	`+`
`179`	`181`	`}`
	`182`	`+ string bitString = sb.ToString();`
	`183`	`+`
`180`	`184`
`181`	`185`	`return GenerateQrCode(bitString, eccLevel, version);`
`182`	`186`	`}`