Skip to content

url payload generator should detect all-caps protocol #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebude merged 3 commits into from
Apr 17, 2024
Merged

url payload generator should detect all-caps protocol #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e88511
url payload generator should detect all-caps protocol
mharen Feb 27, 2023
50999a9
Update QRCoder/PayloadGenerator.cs
mharen Apr 8, 2024
9f712fe
Merge branch 'master' into all-caps-url-payload-generator
mharen Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions QRCoder/PayloadGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ public class Url : Payload
private readonly string url;

/// <summary>
/// Generates a link. If not given, http/https protocol will be added.
/// Generates a link. If the protocol is not specified, the http protocol will be added.
/// </summary>
/// <param name="url">Link url target</param>
public Url(string url)
Expand All @@ -321,7 +321,7 @@ public Url(string url)

public override string ToString()
{
return (!this.url.StartsWith("http") ? "http://" + this.url : this.url);
return (!this.url.StartsWith("http", StringComparison.OrdinalIgnoreCase) ? "http://" + this.url : this.url);
}
}

Expand Down
12 changes: 12 additions & 0 deletions QRCoderTests/PayloadGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,18 @@ public void url_should_build_https()
}


[Fact]
[Category("PayloadGenerator/Url")]
public void url_should_build_https_all_caps()
{
var url = "HTTPS://CODE-BUDE.NET";

var generator = new PayloadGenerator.Url(url);

generator.ToString().ShouldBe("HTTPS://CODE-BUDE.NET");
}


[Fact]
[Category("PayloadGenerator/Url")]
public void url_should_add_http()
Expand Down