Skip to content

Commit 17e0919

Browse files
authored
fix(types): CustomLocator typing broken for custom strict locators (#4120)
1 parent 9a05c17 commit 17e0919

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

typings/index.d.ts

+9-6
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ declare namespace CodeceptJS {
9797
* }
9898
* }
9999
* ```
100-
*/
100+
*/
101101
helpers?: {
102102
/**
103103
* Run web tests controlling browsers via Playwright engine.
@@ -289,7 +289,7 @@ declare namespace CodeceptJS {
289289
* ```js
290290
* bootstrap: 'bootstrap.js',
291291
* ```
292-
*/
292+
*/
293293
bootstrap?: (() => Promise<void>) | boolean | string;
294294
/**
295295
* [Execute code after tests](https://codecept.io/bootstrap/) finished.
@@ -303,7 +303,7 @@ declare namespace CodeceptJS {
303303
* ```js
304304
* teardown: 'teardown.js',
305305
* ```
306-
*/
306+
*/
307307
teardown?: (() => Promise<void>) | boolean | string;
308308
/**
309309
* [Execute code before launching tests in parallel mode](https://codecept.io/bootstrap/#bootstrapall-teardownall)
@@ -312,7 +312,7 @@ declare namespace CodeceptJS {
312312
bootstrapAll?: (() => Promise<void>) | boolean | string;
313313
/**
314314
* [Execute JS code after finishing tests in parallel mode](https://codecept.io/bootstrap/#bootstrapall-teardownall)
315-
*/
315+
*/
316316
teardownAll?: (() => Promise<void>) | boolean | string;
317317

318318
/** Enable [localized test commands](https://codecept.io/translation/) */
@@ -328,7 +328,7 @@ declare namespace CodeceptJS {
328328
* ```
329329
* require: ["should"]
330330
* ```
331-
*/
331+
*/
332332
require?: Array<string>;
333333

334334
/**
@@ -423,15 +423,18 @@ declare namespace CodeceptJS {
423423
| { ios: string }
424424
| { android: string; ios: string }
425425
| { react: string }
426+
| { vue: string }
426427
| { shadow: string[] }
427428
| { custom: string };
428429

429430
interface CustomLocators {}
431+
interface OtherLocators { props?: object }
430432
type LocatorOrString =
431433
| string
432434
| ILocator
433435
| Locator
434-
| CustomLocators;
436+
| OtherLocators
437+
| CustomLocators[keyof CustomLocators];
435438

436439
type StringOrSecret = string | CodeceptJS.Secret;
437440

0 commit comments

Comments
 (0)