From 7dba72b1a114040454d029e68b3948aef3a04a30 Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:14:39 +0200 Subject: [PATCH 01/40] check tests with actions --- .github/workflows/main.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .github/workflows/main.yml diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml new file mode 100644 index 0000000..d6f1d48 --- /dev/null +++ b/.github/workflows/main.yml @@ -0,0 +1,15 @@ +on: [push] + +jobs: + test: + runs-on: ubuntu-latest + name: Tests + steps: + - name: Check current tests + id: check + uses: testomatio/check-tests + with: + framework: codeceptjs + tests: todomvc-tests/**_test.js + token: ${{ secrets.GITHUB_TOKEN }} + \ No newline at end of file From 876d1464c06f0843d2d00646c9590f7e69b15590 Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:16:02 +0200 Subject: [PATCH 02/40] check tests with actions --- .github/workflows/main.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d6f1d48..b45bd10 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,9 +7,8 @@ jobs: steps: - name: Check current tests id: check - uses: testomatio/check-tests + uses: testomatio/check-tests@v1 with: framework: codeceptjs tests: todomvc-tests/**_test.js token: ${{ secrets.GITHUB_TOKEN }} - \ No newline at end of file From 07716f8c765a9f87d3c992d4f9100fa3f92003b7 Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:20:51 +0200 Subject: [PATCH 03/40] check tests with actions, set version --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index b45bd10..cec3703 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,7 +7,7 @@ jobs: steps: - name: Check current tests id: check - uses: testomatio/check-tests@v1 + uses: testomatio/check-tests@v0.1 with: framework: codeceptjs tests: todomvc-tests/**_test.js From 950c762411e864c5f2f226c0a9cce838f255422e Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:23:22 +0200 Subject: [PATCH 04/40] check tests with actions, set version --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index cec3703..5cca457 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,7 +7,7 @@ jobs: steps: - name: Check current tests id: check - uses: testomatio/check-tests@v0.1 + uses: testomatio/check-tests@v0.2 with: framework: codeceptjs tests: todomvc-tests/**_test.js From 0a5d2f621815e01a2ec51a20ad402df02465eaec Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:28:47 +0200 Subject: [PATCH 05/40] changed path for tests --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5cca457..68a566f 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -10,5 +10,5 @@ jobs: uses: testomatio/check-tests@v0.2 with: framework: codeceptjs - tests: todomvc-tests/**_test.js + tests: "./todomvc-tests/**_test.js" token: ${{ secrets.GITHUB_TOKEN }} From 51673d356a7cc5574c8a8528682d41d601791c09 Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:36:39 +0200 Subject: [PATCH 06/40] added github workspace env --- .github/workflows/main.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 68a566f..aefbe8d 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -5,9 +5,8 @@ jobs: runs-on: ubuntu-latest name: Tests steps: - - name: Check current tests - id: check - uses: testomatio/check-tests@v0.2 + - uses: actions/checkout@v2 + - uses: testomatio/check-tests@master with: framework: codeceptjs tests: "./todomvc-tests/**_test.js" From 9a0dba75e5710e1a5bfba920def928f243b72dcd Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:45:58 +0200 Subject: [PATCH 07/40] check tests with actions, set version --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index aefbe8d..1a25f7b 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -9,5 +9,6 @@ jobs: - uses: testomatio/check-tests@master with: framework: codeceptjs + branch: check-tests tests: "./todomvc-tests/**_test.js" token: ${{ secrets.GITHUB_TOKEN }} From 65d0eb766719620ea93c13ceae00cbd277c36a2a Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 04:52:42 +0200 Subject: [PATCH 08/40] added github workspace env --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 1a25f7b..7e670fa 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -9,6 +9,6 @@ jobs: - uses: testomatio/check-tests@master with: framework: codeceptjs - branch: check-tests tests: "./todomvc-tests/**_test.js" + branch: check-tests token: ${{ secrets.GITHUB_TOKEN }} From d6c1d668a1dd03dfee7deb81b1c120038e17087e Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 05:50:09 +0200 Subject: [PATCH 09/40] updated to compare with head --- .github/workflows/main.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7e670fa..28e29bd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -6,6 +6,10 @@ jobs: name: Tests steps: - uses: actions/checkout@v2 + - uses: actions/checkout@v2 + with: + ref: ${{ github.event.pull_request.head.sha }} + path: gh-head - uses: testomatio/check-tests@master with: framework: codeceptjs From 0f7cea71b1b482c36001b547aee40adea529b20f Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 06:11:53 +0200 Subject: [PATCH 10/40] changed config --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 28e29bd..4b707e4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -5,11 +5,11 @@ jobs: runs-on: ubuntu-latest name: Tests steps: - - uses: actions/checkout@v2 - uses: actions/checkout@v2 with: ref: ${{ github.event.pull_request.head.sha }} path: gh-head + - uses: actions/checkout@v2 - uses: testomatio/check-tests@master with: framework: codeceptjs From 0e0f58b71cf39d4eb0a1d8cb97b2feffd1a723f6 Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 06:15:29 +0200 Subject: [PATCH 11/40] changed config --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4b707e4..28e29bd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -5,11 +5,11 @@ jobs: runs-on: ubuntu-latest name: Tests steps: + - uses: actions/checkout@v2 - uses: actions/checkout@v2 with: ref: ${{ github.event.pull_request.head.sha }} path: gh-head - - uses: actions/checkout@v2 - uses: testomatio/check-tests@master with: framework: codeceptjs From 15ed46b863fdf464e65b4cd439542311debae6ec Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 06:32:46 +0200 Subject: [PATCH 12/40] minor change --- todomvc-tests/create-todos_test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 24066bc..20cf6dc 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -21,7 +21,6 @@ Scenario('Create a new todo item', async (I, TodosPage) => { Scenario('Create multiple todo items', async (I, TodosPage) => { I.say('Given I have an empty todo list') - I.say('When I create todos "foo", "bar" and "baz"') TodosPage.enterTodo('foo') TodosPage.enterTodo('bar') From 6fa945c31f8415c500f801182891b9b24324dfb9 Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 06:45:09 +0200 Subject: [PATCH 13/40] minor change --- todomvc-tests/create-todos_test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 20cf6dc..07c9347 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -4,6 +4,7 @@ Before(async (I, TodosPage) => { TodosPage.goto() }); + /** * Happy Path tests */ From 4a07511a3220ac8215c35ef7a3a7bbff37a1099c Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 06:48:00 +0200 Subject: [PATCH 14/40] minor change --- todomvc-tests/create-todos_test.js | 1 - 1 file changed, 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 07c9347..20cf6dc 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -4,7 +4,6 @@ Before(async (I, TodosPage) => { TodosPage.goto() }); - /** * Happy Path tests */ From 3e2f2696bcf0634d1512fe65a3eac38ab7cc1e01 Mon Sep 17 00:00:00 2001 From: Davert Date: Sun, 22 Dec 2019 06:52:14 +0200 Subject: [PATCH 15/40] minor change --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 20cf6dc..92adc12 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -17,7 +17,7 @@ Scenario('Create a new todo item', async (I, TodosPage) => { TodosPage.seeNumberOfTodos(1) I.saveScreenshot('create-todo-item.png') -}) +}); Scenario('Create multiple todo items', async (I, TodosPage) => { I.say('Given I have an empty todo list') From 0f6cb05f6429309709dead7d7ac699ba07995d41 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 00:32:50 +0200 Subject: [PATCH 16/40] skipped 2 tests --- todomvc-tests/create-todos_test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 92adc12..d4a2f7d 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -19,7 +19,7 @@ Scenario('Create a new todo item', async (I, TodosPage) => { I.saveScreenshot('create-todo-item.png') }); -Scenario('Create multiple todo items', async (I, TodosPage) => { +xScenario('Create multiple todo items', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I create todos "foo", "bar" and "baz"') TodosPage.enterTodo('foo') @@ -61,7 +61,7 @@ Scenario('Text input field should be cleared after each item', async (I, TodosPa TodosPage.seeEmptyTodoInput() }) -Scenario('Text input should be trimmed', async (I, TodosPage) => { +xScenario('Text input should be trimmed', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I enter a todo with whitespace around the text') TodosPage.enterTodo(' Todo with lots of whitespace around ') From cb636c68874f846f056193efe86ad90f5b4f9665 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 00:35:25 +0200 Subject: [PATCH 17/40] skipped 2 tests --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index d4a2f7d..37913e8 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -71,7 +71,7 @@ xScenario('Text input should be trimmed', async (I, TodosPage) => { }) -Scenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { +xScenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { I.say('Given I added some todos') TodosPage.enterTodo('first') TodosPage.enterTodo('second') From 68c903d07efc1562a66610bff67046fbca4abb34 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 00:45:53 +0200 Subject: [PATCH 18/40] skipped tests --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 37913e8..d4a2f7d 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -71,7 +71,7 @@ xScenario('Text input should be trimmed', async (I, TodosPage) => { }) -xScenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { +Scenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { I.say('Given I added some todos') TodosPage.enterTodo('first') TodosPage.enterTodo('second') From 264d55fc12d4dc030f30bfa7926de7d90440dbde Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 00:51:37 +0200 Subject: [PATCH 19/40] skipped 2 tests --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index d4a2f7d..37913e8 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -71,7 +71,7 @@ xScenario('Text input should be trimmed', async (I, TodosPage) => { }) -Scenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { +xScenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { I.say('Given I added some todos') TodosPage.enterTodo('first') TodosPage.enterTodo('second') From 7e2949d326a4a35db3e3c27447ff087c66b36771 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 01:00:38 +0200 Subject: [PATCH 20/40] skipped tests --- .github/workflows/main.yml | 4 ++-- todomvc-tests/create-todos_test.js | 14 +++++++++++++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 28e29bd..7013399 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -8,8 +8,8 @@ jobs: - uses: actions/checkout@v2 - uses: actions/checkout@v2 with: - ref: ${{ github.event.pull_request.head.sha }} - path: gh-head + ref: ${{ github.event.pull_request.base.sha }} + path: gh-base - uses: testomatio/check-tests@master with: framework: codeceptjs diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 37913e8..783ce37 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -19,6 +19,18 @@ Scenario('Create a new todo item', async (I, TodosPage) => { I.saveScreenshot('create-todo-item.png') }); +Scenario('Another test', async (I, TodosPage) => { + I.say('Given I have an empty todo list') + + I.say('When I create a todo "foo"') + TodosPage.enterTodo('foo') + + I.say('Then I see the new todo on my list') + TodosPage.seeNumberOfTodos(1) + + I.saveScreenshot('create-todo-item.png') +}); + xScenario('Create multiple todo items', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I create todos "foo", "bar" and "baz"') @@ -61,7 +73,7 @@ Scenario('Text input field should be cleared after each item', async (I, TodosPa TodosPage.seeEmptyTodoInput() }) -xScenario('Text input should be trimmed', async (I, TodosPage) => { +Scenario('Text input should be trimmed', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I enter a todo with whitespace around the text') TodosPage.enterTodo(' Todo with lots of whitespace around ') From 789914ec2227dbc00248577bdbf16f8caa75927a Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 01:16:39 +0200 Subject: [PATCH 21/40] updated config --- .github/workflows/main.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7013399..7e670fa 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -6,10 +6,6 @@ jobs: name: Tests steps: - uses: actions/checkout@v2 - - uses: actions/checkout@v2 - with: - ref: ${{ github.event.pull_request.base.sha }} - path: gh-base - uses: testomatio/check-tests@master with: framework: codeceptjs From 3593f384604555bf92cb04a3e12f3e8bafa4e0d1 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 01:26:11 +0200 Subject: [PATCH 22/40] updated config --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7e670fa..bbc7f41 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -6,6 +6,8 @@ jobs: name: Tests steps: - uses: actions/checkout@v2 + with: + fetch-depth: 2 - uses: testomatio/check-tests@master with: framework: codeceptjs From 05376e12aa59a760b3f7b7b46d87577266f8d52c Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 01:58:59 +0200 Subject: [PATCH 23/40] fixed head --- .github/workflows/main.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index bbc7f41..e872e67 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -6,11 +6,10 @@ jobs: name: Tests steps: - uses: actions/checkout@v2 - with: - fetch-depth: 2 - uses: testomatio/check-tests@master with: framework: codeceptjs tests: "./todomvc-tests/**_test.js" branch: check-tests token: ${{ secrets.GITHUB_TOKEN }} + compare: ${{ github.event.pull_request.base.sha }} From ef2de95f90ccaebadfaaccbb858422f06af8cb88 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 02:13:12 +0200 Subject: [PATCH 24/40] fixed branch --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index e872e67..70d7549 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -6,10 +6,10 @@ jobs: name: Tests steps: - uses: actions/checkout@v2 + with: + fetch-depth: 2 - uses: testomatio/check-tests@master with: framework: codeceptjs tests: "./todomvc-tests/**_test.js" - branch: check-tests token: ${{ secrets.GITHUB_TOKEN }} - compare: ${{ github.event.pull_request.base.sha }} From 4c257203893c38600d5c686f1086c3f784b518c7 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 02:22:46 +0200 Subject: [PATCH 25/40] fixed branch --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 783ce37..e4d96b4 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -73,7 +73,7 @@ Scenario('Text input field should be cleared after each item', async (I, TodosPa TodosPage.seeEmptyTodoInput() }) -Scenario('Text input should be trimmed', async (I, TodosPage) => { +xScenario('Text input should be trimmed', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I enter a todo with whitespace around the text') TodosPage.enterTodo(' Todo with lots of whitespace around ') From 521b33dba8b8fe515042f6198a705b3d54beb083 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 02:28:22 +0200 Subject: [PATCH 26/40] fixed branch commits --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 70d7549..5de5e52 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -7,7 +7,7 @@ jobs: steps: - uses: actions/checkout@v2 with: - fetch-depth: 2 + fetch-depth: 0 - uses: testomatio/check-tests@master with: framework: codeceptjs From 1f0b2a35d17532ccef492205addb4c7abc2be8d3 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 02:58:04 +0200 Subject: [PATCH 27/40] fixed branch commits --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index e4d96b4..783ce37 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -73,7 +73,7 @@ Scenario('Text input field should be cleared after each item', async (I, TodosPa TodosPage.seeEmptyTodoInput() }) -xScenario('Text input should be trimmed', async (I, TodosPage) => { +Scenario('Text input should be trimmed', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I enter a todo with whitespace around the text') TodosPage.enterTodo(' Todo with lots of whitespace around ') From a669ae322e31174942bc7f7b8d2ce9cbdc49e4d8 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 03:01:46 +0200 Subject: [PATCH 28/40] fixed branch commits --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 783ce37..4ad8ac3 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -64,7 +64,7 @@ Scenario('Todos containing weird characters', async (I, current, TodosPage) => { } }) -Scenario('Text input field should be cleared after each item', async (I, TodosPage) => { +xScenario('Text input field should be cleared after each item', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I enter a new todo') TodosPage.enterTodo('foo') From 8bb8dc5e400ac3ad343abaf2f109223b67dca4fa Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 03:03:20 +0200 Subject: [PATCH 29/40] fixed branch commits --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 4ad8ac3..783ce37 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -64,7 +64,7 @@ Scenario('Todos containing weird characters', async (I, current, TodosPage) => { } }) -xScenario('Text input field should be cleared after each item', async (I, TodosPage) => { +Scenario('Text input field should be cleared after each item', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I enter a new todo') TodosPage.enterTodo('foo') From b75e8e681544a059b6ddfccba3bf5d3f10f151f8 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 03:22:04 +0200 Subject: [PATCH 30/40] fixed branch commits --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 783ce37..bcc7751 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -83,7 +83,7 @@ Scenario('Text input should be trimmed', async (I, TodosPage) => { }) -xScenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { +Scenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { I.say('Given I added some todos') TodosPage.enterTodo('first') TodosPage.enterTodo('second') From c85df30301ec88a97284c2455a438ec2edba22da Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 03:24:27 +0200 Subject: [PATCH 31/40] fixed branch commits --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index bcc7751..783ce37 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -83,7 +83,7 @@ Scenario('Text input should be trimmed', async (I, TodosPage) => { }) -Scenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { +xScenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { I.say('Given I added some todos') TodosPage.enterTodo('first') TodosPage.enterTodo('second') From ac4e9494874fb60d489ef5ca7c560b9f4321e875 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 03:32:16 +0200 Subject: [PATCH 32/40] fixed branch commits --- todomvc-tests/create-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index 783ce37..bcc7751 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -83,7 +83,7 @@ Scenario('Text input should be trimmed', async (I, TodosPage) => { }) -xScenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { +Scenario('New todos should be added to the bottom of the list', async (I, TodosPage) => { I.say('Given I added some todos') TodosPage.enterTodo('first') TodosPage.enterTodo('second') From 819351329df54b4109f5da0039081525c179307f Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 03:56:36 +0200 Subject: [PATCH 33/40] add test label --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5de5e52..ce56c99 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,3 +13,4 @@ jobs: framework: codeceptjs tests: "./todomvc-tests/**_test.js" token: ${{ secrets.GITHUB_TOKEN }} + has-tests-label: with_tests From d65e217ad22e0df012790c183a001c55f5dd5406 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 04:11:15 +0200 Subject: [PATCH 34/40] add test label --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ce56c99..8c2f935 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -13,4 +13,4 @@ jobs: framework: codeceptjs tests: "./todomvc-tests/**_test.js" token: ${{ secrets.GITHUB_TOKEN }} - has-tests-label: with_tests + has-tests-label: true From f0f6cb8ad8e8251194b14ccb1286f4ff3ef075a2 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 04:13:38 +0200 Subject: [PATCH 35/40] add test label --- .github/workflows/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 8c2f935..20dd8d8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -14,3 +14,4 @@ jobs: tests: "./todomvc-tests/**_test.js" token: ${{ secrets.GITHUB_TOKEN }} has-tests-label: true + From 292895e2a1082386b0c09db63ce50caafbc3f4b7 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 04:34:23 +0200 Subject: [PATCH 36/40] add only label --- todomvc-tests/edit-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/edit-todos_test.js b/todomvc-tests/edit-todos_test.js index e97bc6f..e5441e5 100644 --- a/todomvc-tests/edit-todos_test.js +++ b/todomvc-tests/edit-todos_test.js @@ -8,7 +8,7 @@ Before(async (I, TodosPage) => { TodosPage.enterTodo('baz') }) -Scenario('Edited todo is saved on blur', async (I, TodosPage) => { +Scenario.only('Edited todo is saved on blur', async (I, TodosPage) => { I.say('Given I have some todos') I.say('When I edit the first todo') From 46236c60137992a1daf9540222b7befabf72c02c Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 04:38:07 +0200 Subject: [PATCH 37/40] add only label --- todomvc-tests/edit-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/edit-todos_test.js b/todomvc-tests/edit-todos_test.js index e5441e5..5e2bfdb 100644 --- a/todomvc-tests/edit-todos_test.js +++ b/todomvc-tests/edit-todos_test.js @@ -20,7 +20,7 @@ Scenario.only('Edited todo is saved on blur', async (I, TodosPage) => { I.saveScreenshot('edited-todo-saved-on-blur.png') }) -Scenario('Delete todos', async (I, TodosPage) => { +Scenario.only('Delete todos', async (I, TodosPage) => { I.say('Given I have some todos') I.say('When I delete the first todo') TodosPage.deleteNthTodo(1) From 99822612adb4c005399d06f1999d269aeb6a4768 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 04:39:35 +0200 Subject: [PATCH 38/40] added .only checks --- todomvc-tests/edit-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/edit-todos_test.js b/todomvc-tests/edit-todos_test.js index 5e2bfdb..e5441e5 100644 --- a/todomvc-tests/edit-todos_test.js +++ b/todomvc-tests/edit-todos_test.js @@ -20,7 +20,7 @@ Scenario.only('Edited todo is saved on blur', async (I, TodosPage) => { I.saveScreenshot('edited-todo-saved-on-blur.png') }) -Scenario.only('Delete todos', async (I, TodosPage) => { +Scenario('Delete todos', async (I, TodosPage) => { I.say('Given I have some todos') I.say('When I delete the first todo') TodosPage.deleteNthTodo(1) From 621ae085d07db76bcc0aa95b0046d00eab5b50b5 Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 04:45:12 +0200 Subject: [PATCH 39/40] fixed .only checks --- todomvc-tests/edit-todos_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/todomvc-tests/edit-todos_test.js b/todomvc-tests/edit-todos_test.js index e5441e5..e97bc6f 100644 --- a/todomvc-tests/edit-todos_test.js +++ b/todomvc-tests/edit-todos_test.js @@ -8,7 +8,7 @@ Before(async (I, TodosPage) => { TodosPage.enterTodo('baz') }) -Scenario.only('Edited todo is saved on blur', async (I, TodosPage) => { +Scenario('Edited todo is saved on blur', async (I, TodosPage) => { I.say('Given I have some todos') I.say('When I edit the first todo') From 71e6cc13b54bfbe4f73cddd709252f4990bd4ded Mon Sep 17 00:00:00 2001 From: Davert Date: Mon, 23 Dec 2019 14:23:36 +0200 Subject: [PATCH 40/40] restored tests --- .github/workflows/main.yml | 5 +++-- todomvc-tests/create-todos_test.js | 14 +------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 20dd8d8..e5833a4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,9 +1,10 @@ on: [push] + jobs: test: runs-on: ubuntu-latest - name: Tests + name: Check Tests steps: - uses: actions/checkout@v2 with: @@ -14,4 +15,4 @@ jobs: tests: "./todomvc-tests/**_test.js" token: ${{ secrets.GITHUB_TOKEN }} has-tests-label: true - + diff --git a/todomvc-tests/create-todos_test.js b/todomvc-tests/create-todos_test.js index bcc7751..92adc12 100644 --- a/todomvc-tests/create-todos_test.js +++ b/todomvc-tests/create-todos_test.js @@ -19,19 +19,7 @@ Scenario('Create a new todo item', async (I, TodosPage) => { I.saveScreenshot('create-todo-item.png') }); -Scenario('Another test', async (I, TodosPage) => { - I.say('Given I have an empty todo list') - - I.say('When I create a todo "foo"') - TodosPage.enterTodo('foo') - - I.say('Then I see the new todo on my list') - TodosPage.seeNumberOfTodos(1) - - I.saveScreenshot('create-todo-item.png') -}); - -xScenario('Create multiple todo items', async (I, TodosPage) => { +Scenario('Create multiple todo items', async (I, TodosPage) => { I.say('Given I have an empty todo list') I.say('When I create todos "foo", "bar" and "baz"') TodosPage.enterTodo('foo')