Skip to content

remove Java heap settings #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2015
Merged

remove Java heap settings #53

merged 1 commit into from
Dec 17, 2015

Conversation

wfleming
Copy link
Contributor

These seem to be causing non-deterministic analysis results from some
behavior in JRuby/the JVM. While we hunt this down, it would be
preferable to not set heap limits & let the engine hard-crash by hitting
container memory limits.

cc @codeclimate/review

These seem to be causing non-deterministic analysis results from some
behavior in JRuby/the JVM. While we hunt this down, it would be
preferable to not set heap limits & let the engine hard-crash by hitting
container memory limits.
@pbrisbin
Copy link
Contributor

Makes sense to me. :shipit:

@brynary
Copy link
Member

brynary commented Dec 17, 2015

Are you sure you want to remove both the min and the max? It sounds like your description is all about the max. Allocating a large enough heap at the beginning is generally faster, as it saves as-you-go heap expansions

@jpignata
Copy link
Contributor

That may be true, but I doubt 128MB is the right value for this. I think
I'd say we remove both for now as Will has done, and wait until our
investigation is complete to set these values more precisely.

On Wed, Dec 16, 2015 at 7:39 PM, Bryan Helmkamp [email protected]
wrote:

Are you sure you want to remove both the min and the max? It sounds like
your description is all about the max. Allocating a large enough heap at
the beginning is generally faster, as it saves as-you-go heap expansions


Reply to this email directly or view it on GitHub
#53 (comment)
.

@brynary
Copy link
Member

brynary commented Dec 17, 2015

Makes sense

wfleming added a commit that referenced this pull request Dec 17, 2015
@wfleming wfleming merged commit de048cc into master Dec 17, 2015
@wfleming wfleming deleted the will/java-heap branch December 17, 2015 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants