Skip to content

Issues for files which do not exist #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrb opened this issue Oct 1, 2015 · 3 comments
Closed

Issues for files which do not exist #18

mrb opened this issue Oct 1, 2015 · 3 comments

Comments

@mrb
Copy link
Contributor

mrb commented Oct 1, 2015

Some static analysis engines emit issues for files which are not a part of the working tree - e.g. some engines will warn you about certain files which don't exist. One way to handle this would be to create a concept of "repo level issues." Another would be to create a way to surface these files in the CC UI and in the CLI. /c @brynary

@wfleming
Copy link
Contributor

wfleming commented Oct 1, 2015

I feel like this is related enough to the issue @ABaldwinHunter ran into brakeman reporting a missing protect_from_forgery (for which there is no line number because it's, you know, missing) that it makes sense to think about the solution to both at once. Basically, I think there are classes of issues for which a location may not reasonably exist, or a file-level location (i.e no line number) may exist, but the file itself may not actually exist.

@mrb
Copy link
Contributor Author

mrb commented Oct 9, 2015

@brynary Opinions on how to handle this?

@fhwang
Copy link
Contributor

fhwang commented Oct 9, 2015

Maybe an optional top-level scope key?

{
  "type": "issue",
  "scope": "repository"
  ...
}

Presumably if you used that then location would not be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants