Skip to content

Commit 5b3e40d

Browse files
committed
docs(npm): add npm_config_build env notes
1 parent 4f9ea04 commit 5b3e40d

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

docs/npm.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
# npm Install Requirements
44

55
- [Ubuntu, Debian](#ubuntu-debian)
6+
- [Distros Older than 18.04](#distros-older-than-1804)
67
- [Fedora, CentOS, RHEL](#fedora-centos-rhel)
78
- [Alpine](#alpine)
89
- [macOS](#macos)
@@ -30,6 +31,13 @@ sudo apt-get install -y \
3031
npm config set python python3
3132
```
3233

34+
### Distros Older than 18.04
35+
36+
If you are using a distro older than Ubntu 18.04 and you are using `yarn global add` to install code-server, please make sure to set `npm_config_build_from_source=true`.
37+
38+
This is due to an upstream issue with RHEL7/CentOS 7 comptability with node-argon2
39+
See details [here](https://github.com/cdr/code-server/pull/3422#pullrequestreview-677765057) and [here](https://github.com/ranisalt/node-argon2/issues/276).
40+
3341
## Fedora, CentOS, RHEL
3442

3543
```bash

src/node/cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ export const parse = (
286286
const split = splitOnFirstEquals(arg.replace(/^--/, ""))
287287
key = split[0] as keyof Args
288288
value = split[1]
289-
289+
}
290290
if (!key || !options[key]) {
291291
throw error(`Unknown option ${arg}`)
292292
}

0 commit comments

Comments
 (0)