Skip to content

Commit 8cc3cc0

Browse files
committed
Simplify query concatenation in URL callback
Cases in URLs like ?&a=b or ?a=b& appear to be handled just fine.
1 parent d14c2e5 commit 8cc3cc0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node/routes/vscode.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ router.get("/callback", ensureAuthenticated, async (req, res) => {
151151
scheme: getFirstString(req.query["vscode-scheme"]) || "code-oss",
152152
authority: getFirstString(req.query["vscode-authority"]),
153153
path: getFirstString(req.query["vscode-path"]),
154-
query: (getFirstString(req.query.query) ? getFirstString(req.query.query) + "&" : "") + qs.stringify(query),
154+
query: getFirstString(req.query.query) + "&" + qs.stringify(query),
155155
fragment: getFirstString(req.query["vscode-fragment"]),
156156
},
157157
// Make sure the map doesn't leak if nothing fetches this URI.

0 commit comments

Comments
 (0)