Skip to content

Commit a76c0c5

Browse files
committed
Remove PR npm package
It is causing CI to fail for Dependabot (no access to the token) and it does not work with forks and currently there is no one who pushes straight to the repo so this will never be used. Can always add it back if we figure out how to make the secrets work.
1 parent 6e1b913 commit a76c0c5

File tree

1 file changed

+1
-60
lines changed

1 file changed

+1
-60
lines changed

.github/workflows/build.yaml

Lines changed: 1 addition & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -283,65 +283,6 @@ jobs:
283283
name: npm-package
284284
path: ./package.tar.gz
285285

286-
npm:
287-
name: Publish npm package
288-
# the npm-package gets uploaded as an artifact in Build
289-
# so we need that to complete before this runs
290-
needs: build
291-
# This environment "npm" requires someone from
292-
# coder/code-server-reviewers to approve the PR before this job runs.
293-
environment: npm
294-
# Only run if PR comes from base repo or event is not a PR
295-
# Reason: forks cannot access secrets and this will always fail
296-
if: github.event.pull_request.head.repo.full_name == github.repository || github.event_name != 'pull_request'
297-
runs-on: ubuntu-20.04
298-
steps:
299-
- name: Checkout repo
300-
uses: actions/checkout@v3
301-
302-
- name: Download artifact
303-
uses: actions/download-artifact@v3
304-
id: download
305-
with:
306-
name: "npm-package"
307-
path: release-npm-package
308-
309-
- name: Run ./ci/steps/publish-npm.sh
310-
run: yarn publish:npm
311-
env:
312-
# NOTE@jsjoeio
313-
# This is because npm enforces semantic versioning
314-
# so it has to be a valid version. We only use this
315-
# to publish dev versions from prs
316-
# and beta versions from main.
317-
VERSION: "0.0.0"
318-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
319-
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
320-
# NOTE@jsjoeio
321-
# NPM_ENVIRONMENT intentionally not set here.
322-
# Instead, itis determined in publish-npm.sh script
323-
# using GITHUB environment variables
324-
325-
- name: Comment npm information
326-
uses: marocchino/sticky-pull-request-comment@v2
327-
with:
328-
GITHUB_TOKEN: ${{ github.token }}
329-
header: npm-dev-build
330-
message: |
331-
✨ code-server dev build published to npm for PR #${{ github.event.number }}!
332-
* _Last publish status_: success
333-
* _Commit_: ${{ github.event.pull_request.head.sha }}
334-
335-
To install in a local project, run:
336-
```shell-session
337-
npm install @coder/code-server-pr@${{ github.event.number }}
338-
```
339-
340-
To install globally, run:
341-
```shell-session
342-
npm install -g @coder/code-server-pr@${{ github.event.number }}
343-
```
344-
345286
test-e2e:
346287
name: Run e2e tests
347288
needs: build
@@ -455,7 +396,7 @@ jobs:
455396
if: steps.caddy-cache.outputs.cache-hit != 'true'
456397
run: |
457398
gh release download v2.5.2 --repo caddyserver/caddy --pattern "caddy_2.5.2_linux_amd64.tar.gz"
458-
mkdir -p ~/.cache/caddy
399+
mkdir -p ~/.cache/caddy
459400
tar -xzf caddy_2.5.2_linux_amd64.tar.gz --directory ~/.cache/caddy
460401
461402
- name: Start Caddy

0 commit comments

Comments
 (0)