Skip to content

Replace bespoke templating with Express #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
GirlBossRush opened this issue Jul 21, 2021 · 1 comment
Closed
3 tasks

Replace bespoke templating with Express #3833

GirlBossRush opened this issue Jul 21, 2021 · 1 comment
Assignees
Labels
enhancement Some improvement that isn't a feature feature New user visible feature
Milestone

Comments

@GirlBossRush
Copy link
Contributor

We once simplified our templating logic during the migration to Express, but some of these changes were lost as code-server was refactored.

Much of these changes can be resurrected and applied to our architecture.

Goals:

  • Reducing the amount of code that duplicates express’s existing page routing
  • Relying on fewer interpolated data passed to the front-end via metatags
  • Simplifying browserify differences between local dev and built artifacts.
@GirlBossRush GirlBossRush added enhancement Some improvement that isn't a feature feature New user visible feature labels Jul 21, 2021
@GirlBossRush GirlBossRush added this to the 3.12.0 milestone Jul 21, 2021
@GirlBossRush GirlBossRush self-assigned this Jul 21, 2021
@GirlBossRush GirlBossRush changed the title Replace bespoke templating with Express Handlebars Replace bespoke templating with Express Jul 21, 2021
@jsjoeio jsjoeio modified the milestones: 3.12.0, On Deck Sep 9, 2021
@stale
Copy link

stale bot commented Mar 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale label Mar 8, 2022
@stale stale bot closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature feature New user visible feature
Projects
None yet
Development

No branches or pull requests

2 participants