Skip to content

[Feat]: Upgrade vscode to 1.70.2 #5470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
balajib-b opened this issue Aug 17, 2022 · 6 comments · Fixed by #5485
Closed

[Feat]: Upgrade vscode to 1.70.2 #5470

balajib-b opened this issue Aug 17, 2022 · 6 comments · Fixed by #5485
Assignees
Labels
enhancement Some improvement that isn't a feature
Milestone

Comments

@balajib-b
Copy link

What is your suggestion?

Upgrade vscode to 1.70.2

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

@balajib-b balajib-b added the enhancement Some improvement that isn't a feature label Aug 17, 2022
@balajib-b
Copy link
Author

balajib-b commented Aug 17, 2022

@jsjoeio @code-asher vscode 1.70.2 is released as hour ago, can we have it along with August 2022?

@bala
Copy link

bala commented Aug 17, 2022

@jsjoeio @code-asher contributing guide Shall I try giving PR based on this contributing guide?

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 17, 2022

can we have it along with August 2022?

I can add it in.

@jsjoeio @code-asher contributing guide Shall I try giving PR based on this contributing guide?

These updates are tough because they require more context than other parts of the codebase. I wouldn't recommend it personally but up to you!

@fritterhoff
Copy link
Contributor

@jsjoeio @code-asher I think porting the latest patches to 1.70.2 should be no problem. Seems like they only patched files that are note affected by the code-server patches. (microsoft/vscode@1.70.1...1.70.2)

@code-asher
Copy link
Member

code-asher commented Aug 18, 2022

Yeah minor version updates can be tough but patch version updates should generally be much easier!

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 18, 2022

Ah, I didn't consider the minor vs. patch - good points! @balajib-b totally up to you then! Go for it if you're feeling inspired - and let us know if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants