Skip to content

[Testing]: fix VSCODE_PROXY_URI flakiness #5472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Aug 17, 2022 · 1 comment · Fixed by #5481
Closed

[Testing]: fix VSCODE_PROXY_URI flakiness #5472

jsjoeio opened this issue Aug 17, 2022 · 1 comment · Fixed by #5481
Labels
enhancement Some improvement that isn't a feature

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 17, 2022

What is your suggestion?

To improve the reliability of the extensions.test.ts test should have access to VSCODE_PROXY_URI which has been failing more than usual in CI lately.

Why do you want this feature?

More confidence in e2e tests and faster working cycle.

Are there any workarounds to get this functionality today?

Re-run the tests manually when they fail.

Are you interested in submitting a PR for this?

Yes.
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Aug 17, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Aug 19, 2022

One idea to fix this is to show a notification when the activate function is called meaning the extension loaded.

@jsjoeio jsjoeio mentioned this issue Aug 19, 2022
Merged
@jsjoeio jsjoeio linked a pull request Aug 19, 2022 that will close this issue
fix(testing): reduce flakiness in extension e2e tests #5481
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(testing): reduce flakiness in extension e2e tests coder/code-server
1 participant
@jsjoeio