Skip to content

Commit 69a6ce4

Browse files
authored
Bypass spurious reload button (#32)
This reload button does nothing which I think must mean there is some logic somewhere that is supposed to load these extensions locally that is not working or not implemented. Until we find it bypassing is probably a good move because otherwise it makes it look like the extension is not running and working even though it really is (it is just running remotely). This will be a temporary measure to solve coder/code-server#4600.
1 parent acfcdb5 commit 69a6ce4

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

src/vs/workbench/contrib/extensions/browser/extensionsActions.ts

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1443,9 +1443,17 @@ export class ReloadAction extends ExtensionAction {
14431443
if (extensionInOtherServer) {
14441444
// This extension prefers to run on UI/Local side but is running in remote
14451445
if (runningExtensionServer === this.extensionManagementServerService.remoteExtensionManagementServer && this.extensionManifestPropertiesService.prefersExecuteOnUI(this.extension.local!.manifest)) {
1446-
this.enabled = true;
1447-
this.label = localize('reloadRequired', "Reload Required");
1448-
this.tooltip = localize('enable locally', "Please reload Visual Studio Code to enable this extension locally.");
1446+
/**
1447+
* This is causing builtin extensions to always show a reload
1448+
* button yet reloading does nothing.
1449+
* TODO@coder: The real problem might be that these extensions
1450+
* are somehow supposed to be running as web extensions instead
1451+
* of in the remote but it is unclear how to make that happen.
1452+
* @author coder
1453+
*/
1454+
// this.enabled = true;
1455+
// this.label = localize('reloadRequired', "Reload Required");
1456+
// this.tooltip = localize('enable locally', "Please reload Visual Studio Code to enable this extension locally.");
14491457
return;
14501458
}
14511459

0 commit comments

Comments
 (0)