Skip to content

Commit 7c5b012

Browse files
committed
ws_js_test: Fix
1 parent 5d45a30 commit 7c5b012

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

close.go

-4
Original file line numberDiff line numberDiff line change
@@ -206,10 +206,6 @@ func (c *Conn) waitCloseHandshake() error {
206206
}
207207
defer c.readMu.unlock()
208208

209-
if c.readCloseFrameErr != nil {
210-
return c.readCloseFrameErr
211-
}
212-
213209
for i := int64(0); i < c.msgReader.payloadLength; i++ {
214210
_, err := c.br.ReadByte()
215211
if err != nil {

conn.go

-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ type Conn struct {
6161
readHeaderBuf [8]byte
6262
readControlBuf [maxControlPayload]byte
6363
msgReader *msgReader
64-
readCloseFrameErr error
6564

6665
// Write state.
6766
msgWriter *msgWriter

conn_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ func TestWasm(t *testing.T) {
363363
ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
364364
defer cancel()
365365

366-
cmd := exec.CommandContext(ctx, "go", "test", "-exec=wasmbrowsertest", ".")
366+
cmd := exec.CommandContext(ctx, "go", "test", "-exec=wasmbrowsertest", ".", "-v")
367367
cmd.Env = append(os.Environ(), "GOOS=js", "GOARCH=wasm", fmt.Sprintf("WS_ECHO_SERVER_URL=%v", s.URL))
368368

369369
b, err := cmd.CombinedOutput()

read.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,7 @@ func (c *Conn) handleControl(ctx context.Context, h header) (err error) {
313313
return nil
314314
}
315315

316-
defer func() {
317-
c.readCloseFrameErr = err
318-
}()
316+
// opClose
319317

320318
ce, err := parseClosePayload(b)
321319
if err != nil {
@@ -326,6 +324,8 @@ func (c *Conn) handleControl(ctx context.Context, h header) (err error) {
326324

327325
err = fmt.Errorf("received close frame: %w", ce)
328326
c.writeClose(ce.Code, ce.Reason)
327+
c.readMu.unlock()
328+
c.close()
329329
return err
330330
}
331331

0 commit comments

Comments
 (0)