Merge remote-tracking branch 'origin/Ghidra_9.2'

Author: ghidra1

Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/function/AnalyzeStackRefsAction.java

@@ -25,6 +25,7 @@
 import ghidra.app.util.HelpTopics;
 import ghidra.framework.cmd.BackgroundCommand;
 import ghidra.framework.options.Options;
+import ghidra.program.model.address.Address;
 import ghidra.program.model.address.AddressSet;
 import ghidra.program.model.lang.GhidraLanguagePropertyKeys;
 import ghidra.program.model.listing.Function;
@@ -118,10 +119,11 @@ public boolean isEnabledForContext(ListingActionContext context) {
 		if (context.hasSelection()) {
 			return true;
 		}
-		Function func = funcPlugin.getFunction(context);
-		if (func != null) {
-			return !func.isExternal();
+		Program program = context.getProgram();
+		Address addr = context.getAddress();
+		if (program == null || addr == null) {
+			return false;
 		}
-		return false;
+		return program.getListing().getFunctionContaining(addr) != null;
 	}
 }

Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/help/AboutProgramPlugin.java

@@ -52,7 +52,7 @@
 //@formatter:on
 public class AboutProgramPlugin extends Plugin implements FrontEndable {
 	public final static String PLUGIN_NAME = "AboutProgramPlugin";
-	public final static String ACTION_NAME = "About program";
+	public final static String ACTION_NAME = "About Program";
 
 	private DockingAction aboutAction;
 
@@ -87,7 +87,8 @@ protected boolean isAddToPopup(ProjectDataContext context) {
 					return context.getFileCount() == 1 && context.getFolderCount() == 0;
 				}
 			};
-			aboutAction.setPopupMenuData(new MenuData(new String[] { "About..." }, null, "AAA"));
+			aboutAction.setPopupMenuData(
+				new MenuData(new String[] { ACTION_NAME }, null, "AAA"));
 
 			aboutAction.setEnabled(true);
 		}
@@ -101,20 +102,17 @@ public void actionPerformed(ProgramActionContext context) {
 
 				@Override
 				public boolean isValidContext(ActionContext context) {
-					updateMenuName(context);
-					return super.isValidContext(context);
-				}
-
-				private void updateMenuName(ActionContext context) {
-					if (context instanceof ProgramActionContext) {
+					if (super.isValidContext(context)) {
 						ProgramActionContext pac = (ProgramActionContext) context;
 						Program program = pac.getProgram();
-						String menuName = "About " + program.getDomainFile().getName();
-						getMenuBarData().setMenuItemName(menuName);
-					}
-					else {
-						getMenuBarData().setMenuItemName(ACTION_NAME);
+						if (program != null) {
+							String menuName = "About " + program.getDomainFile().getName() + "...";
+							getMenuBarData().setMenuItemName(menuName);
+							return true;
+						}
 					}
+					getMenuBarData().setMenuItemName(ACTION_NAME);
+					return false;
 				}
 			};
 			aboutAction.setSupportsDefaultToolContext(true);

Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/progmgr/ProgramManagerPlugin.java

@@ -659,19 +659,11 @@ private void updateActions() {
 		Program p = programMgr.getCurrentProgram();
 		updateCloseAction(p);
 		updateProgramOptionsAction(p);
-		updateSaveAction(p);
-		updateSaveAsAction(p);
+		updateProgramActions();
 		closeAllAction.setEnabled(p != null);
 		optionsAction.setEnabled(p != null);
 		Program[] programList = programMgr.getAllPrograms();
 		closeOthersAction.setEnabled(programList.length > 1);
-		saveAllAction.setEnabled(false);
-		for (Program element : programList) {
-			if (element.isChanged()) {
-				saveAllAction.setEnabled(true);
-				break;
-			}
-		}
 		tool.contextChanged(null);
 	}
 

Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/progmgr/RedoAction.java

@@ -19,7 +19,6 @@
 
 import javax.swing.Icon;
 
-import docking.ActionContext;
 import docking.action.*;
 import docking.tool.ToolConstants;
 import ghidra.app.context.ProgramActionContext;
@@ -93,15 +92,6 @@ else if (program.canRedo()) {
 
 	}
 
-	@Override
-	public boolean isValidContext(ActionContext context) {
-		if (!(context instanceof ProgramActionContext)) {
-			getMenuBarData().setMenuItemName("Redo ");
-			setDescription("");
-		}
-		return super.isValidContext(context);
-	}
-
 	@Override
 	protected boolean isEnabledForContext(ProgramActionContext context) {
 		Program program = context.getProgram();

Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/progmgr/UndoAction.java

@@ -19,7 +19,6 @@
 
 import javax.swing.Icon;
 
-import docking.ActionContext;
 import docking.action.*;
 import docking.tool.ToolConstants;
 import ghidra.app.context.ProgramActionContext;
@@ -99,15 +98,6 @@ public void update(Program program) {
 		}
 	}
 
-	@Override
-	public boolean isValidContext(ActionContext context) {
-		if (!(context instanceof ProgramActionContext)) {
-			getMenuBarData().setMenuItemName("Undo ");
-			setDescription("");
-		}
-		return super.isValidContext(context);
-	}
-
 	@Override
 	protected boolean isEnabledForContext(ProgramActionContext context) {
 		Program program = context.getProgram();