-
Notifications
You must be signed in to change notification settings - Fork 1
Deduplicate - Count Digits of Factorial #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
My vote: |
keep 1 retire 2 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I voted for keeping 1. since it has many languages and rank is appropriate and require less migration from the other one. Only thing is to add edge cases for all languages, update them to latest framework and migrate Factor from myjinxin's one! |
@FArekkusu please see this discussion for follow-up: #68 |
While I think the title and rank of the first one are better, if changing the rank of the second one is fairly simple then I think I would prefer to keep the second one and rerank. The second one is older, after all, and I think with everything else being close to equal, the older kata should have priority. If reranking is undesirable, then the first one should be chosen. However if we are comparing levels of work/effort, I think that the effort spent reranking the second kata will still be less than the potential effort spent "working around" a troublesome author.
Well, I would be unable to even post a migration of my translation to the other kata as a suggestion, due to being blocked. :) |
I thought this was more 5kyu than 6kyu but everyone disagrees so maybe I'm just dumb |
If that reassures you, I also think it could be rather an (easy) 5 kyu rather than 6, but the solution is spoiled all over the internet... About KenKamau, for known reasons he should not be considered an active maintainer, but anyone can contribute to katas so it's not such a big problem. Eventually, keep 1 could be the best solution. |
My vote: 1.Factorial length |
|
Uh oh!
There was an error while loading. Please reload this page.
Both kata allow for O(n) solutions (sum of logs), or even O(n log n) solutions (split all of 1...n into digits), at least in languages I checked. None of them seems to enforce a O(1) solution. None of them seems to allow for solutions based on naive multiplication.
The text was updated successfully, but these errors were encountered: