Skip to content

Deduplicate - Count Digits of Factorial #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobovsky opened this issue Jan 24, 2022 · 13 comments
Open

Deduplicate - Count Digits of Factorial #67

hobovsky opened this issue Jan 24, 2022 · 13 comments
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Jan 24, 2022

  1. Factorial length
  • 6 kyu
  • No fixed tests for edge cases (zero, eventually 1)
  • Satisfaction 83%, 626 solutions
  • No pending issues
  • 6 languages + 3 pending translations
  • Published Oct 2017, authored by KenKamau (active)
  1. Simple Fun #206: Factorial Digits
  • 5 kyu
  • Satisfaction 90%, 318 solutions
  • No pending issues
  • 6 languages + 1 pending translation
  • Published Apr 2017, authored by myjinxin2015 (inactive)

Both kata allow for O(n) solutions (sum of logs), or even O(n log n) solutions (split all of 1...n into digits), at least in languages I checked. None of them seems to enforce a O(1) solution. None of them seems to allow for solutions based on naive multiplication.

@hobovsky hobovsky added the discussion/deduplicate Discussion and vote what to do with duplicate kata label Jan 24, 2022
@hobovsky
Copy link
Contributor Author

My vote:
I do not have a strong preference here, but I lean towards keeping 1. as ranked more accurately, having more languages, and being actively maintained. 2. would be retired.

@krishsharma0413
Copy link

keep 1 retire 2

@FArekkusu

This comment has been minimized.

@hobovsky

This comment has been minimized.

@FArekkusu

This comment has been minimized.

@hobovsky

This comment has been minimized.

@ejini6969
Copy link

I voted for keeping 1. since it has many languages and rank is appropriate and require less migration from the other one.

Only thing is to add edge cases for all languages, update them to latest framework and migrate Factor from myjinxin's one!

@hobovsky
Copy link
Contributor Author

@FArekkusu please see this discussion for follow-up: #68

@Kacarott
Copy link

While I think the title and rank of the first one are better, if changing the rank of the second one is fairly simple then I think I would prefer to keep the second one and rerank. The second one is older, after all, and I think with everything else being close to equal, the older kata should have priority.

If reranking is undesirable, then the first one should be chosen. However if we are comparing levels of work/effort, I think that the effort spent reranking the second kata will still be less than the potential effort spent "working around" a troublesome author.

and migrate Factor from myjinxin's one!

Well, I would be unable to even post a migration of my translation to the other kata as a suggestion, due to being blocked. :)

@EloiseRosen
Copy link

I thought this was more 5kyu than 6kyu but everyone disagrees so maybe I'm just dumb

@akar-0
Copy link

akar-0 commented Feb 19, 2022

I thought this was more 5kyu than 6kyu but everyone disagrees so maybe I'm just dumb

If that reassures you, I also think it could be rather an (easy) 5 kyu rather than 6, but the solution is spoiled all over the internet... About KenKamau, for known reasons he should not be considered an active maintainer, but anyone can contribute to katas so it's not such a big problem. Eventually, keep 1 could be the best solution.

@armeanco
Copy link

My vote: 1.Factorial length

@KayleighWasTaken
Copy link

KayleighWasTaken commented Jan 28, 2024

  1. no longer allows O(n) solutions to pass in Python, only O(1), 2. is unaffected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Status: Discussing
Development

No branches or pull requests

9 participants