Skip to content

Commit 11ee148

Browse files
authored
Merge pull request #178 from codingtools/cdt-177
Node upgrade failing for v14+ on adding addition Node Version for CI
2 parents 218d028 + 37b0271 commit 11ee148

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

.github/workflows/nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
10-
node-version: [10.x, 11.x, 12.x, 13.x]
10+
node-version: [10.x, 11.x, 12.x, 13.x, 14.x, 15.x]
1111

1212
steps:
1313
- uses: actions/checkout@v2

.github/workflows/npmpublish.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
- v0.1.*
77
- v0.2.*
88
- v0.*.*
9+
- v1.*.*
910

1011
jobs:
1112
build:

src/utilities/utilities.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default class Utilities {
4646
else
4747
Logger.warn(thisRef, `File already exists: ${chalk.green(filePath)}, ${chalk.yellow('overriding content')}`) // this will output error and exit command
4848

49-
fs.writeFileSync(filePath, string)
49+
fs.writeFileSync(filePath, string.toString())
5050

5151
if (string !== '') // this condition comes for truncating
5252
Logger.success(thisRef, `output written to file: ${chalk.green(filePath)}`) // this will output error and exit command

test/resources/scripts/pr_helper.sh

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,26 @@ PR=159
33
# checkout pr
44
gh pr checkout $PR
55

6-
6+
git pull origin release/release-v0.x
77
# npm install
88
npm install
99

10+
#COMMIT
1011

12+
git push
1113
# GIT PUSH and then checks ( validate )
1214
# watching checks running
13-
watch -n 3 "gh pr checks $PR"
14-
15+
#watch -n 3 "gh pr checks $PR"
16+
watch -n 3 "
17+
gh pr checks $PR; echo '---------------';
18+
echo 'PENDING:'
19+
gh pr checks $PR | grep -o pend | wc -w;
20+
echo
21+
echo 'PASSED:'
22+
gh pr checks $PR | grep -o pass | wc -w;
23+
echo
24+
echo 'FAILED:'
25+
gh pr checks $PR | grep -o fail | wc -w;
26+
";
1527
#MERGE PR
1628
gh pr merge $PR -d -m
17-

0 commit comments

Comments
 (0)