Skip to content

Commit 3d0a483

Browse files
authored
Merge pull request #6344 from cabalism/add/build-ghc-x.y.z-6342
Build _ with ghc-x.y.z
2 parents 0c11fba + e180ed0 commit 3d0a483

File tree

4 files changed

+8
-4
lines changed

4 files changed

+8
-4
lines changed

.stan.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363

6464
# Anti-pattern: Data.ByteString.Char8.pack
6565
[[ignore]]
66-
id = "OBS-STAN-0203-fki0nd-2666:3"
66+
id = "OBS-STAN-0203-fki0nd-2668:3"
6767
# ✦ Description: Usage of 'pack' function that doesn't handle Unicode characters
6868
# ✦ Category: #AntiPattern
6969
# ✦ File: src\Stack\Build\Execute.hs

ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ Other enhancements:
4646
found. In YAML configuration files, the `notify-if-ghc-untested` and
4747
`notify-if-cabal-untested` keys are introduced, to allow the notification to
4848
be muted if unwanted.
49+
* The compiler version is included in Stack's build message (e.g.
50+
`stack> build (lib + exe + test) with ghc-9.4.7`).
4951

5052
Bug fixes:
5153
* Fix the `Curator` instance of `ToJSON`, as regards `expect-haddock-failure`.

doc/GUIDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ stack build :helloworld-test
981981
Building all executables for `helloworld' once. After a successful build of all of them, only specified executables will be rebuilt.
982982
helloworld> configure (lib + exe + test)
983983
Configuring helloworld-0.1.0.0...
984-
helloworld> build (lib + exe + test)
984+
helloworld> build (lib + exe + test) with ghc-x.y.z
985985
Preprocessing library for helloworld-0.1.0.0..
986986
Building library for helloworld-0.1.0.0..
987987
[1 of 2] Compiling Lib
@@ -1024,7 +1024,7 @@ and command again:
10241024
~~~text
10251025
stack build :helloworld-test
10261026
helloworld-0.1.0.0: unregistering (local file changes: test\Spec.hs)
1027-
helloworld> build (lib + test)
1027+
helloworld> build (lib + test) with ghc-x.y.z
10281028
Preprocessing library for helloworld-0.1.0.0..
10291029
Building library for helloworld-0.1.0.0..
10301030
Preprocessing test suite 'helloworld-test' for helloworld-0.1.0.0..

src/Stack/Build/Execute.hs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1985,9 +1985,12 @@ singleBuild
19851985
\undefined reference errors from the linker, along with \
19861986
\other problems."
19871987

1988+
actualCompiler <- view actualCompilerVersionL
19881989
() <- announce
19891990
( "build"
19901991
<> display (annSuffix executableBuildStatuses)
1992+
<> " with "
1993+
<> display actualCompiler
19911994
)
19921995
config <- view configL
19931996
extraOpts <- extraBuildOptions wc eeBuildOpts
@@ -2017,7 +2020,6 @@ singleBuild
20172020
else "haddock"
20182021

20192022
-- For GHC 8.4 and later, provide the --quickjump option.
2020-
actualCompiler <- view actualCompilerVersionL
20212023
let quickjump =
20222024
case actualCompiler of
20232025
ACGhc ghcVer

0 commit comments

Comments
 (0)