Skip to content

Add stack setup --install-cabal VERSION in addition to stack setup --upgrade-cabal. #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjakobi opened this issue Jul 18, 2016 · 5 comments

Comments

@sjakobi
Copy link
Member

sjakobi commented Jul 18, 2016

This should make it easier to test stack with different versions of Cabal, as required for e.g. #2350.

@sjakobi
Copy link
Member Author

sjakobi commented Jul 18, 2016

A few pointers:

  • Most (all?) of the related code lives in either Stack.SetupCmd or Stack.Setup.
  • I'd suggest generalizing Stack.Setup.ugradeCabal to installCabal so it can accept a concrete version or default to the newest available version of Cabal

@Blaisorblade
Copy link
Collaborator

What about picking a fixed cabal-install version for each stack version, and installing it in isolation? Ideally, the newest one for the supported cabal library.
(Why is stack not yet on Cabal 1.24 BTW?)

@borsboom
Copy link
Contributor

Stack doesn't use cabal-install for much (just the solver AFAIK) so not really any need to have cabal-install match the Cabal library version it was built with. For building Stack, we stick with the versions of packages that are in the current LTS snapshot unless there's a really compelling reason to add an extra-dep, so once LTS 7 is released Stack will upgrade to a newer Cabal library version (along with building with GHC 8.0.1). And we haven't been in a rush to have Stack use Cabal-1.24 because we don't need any of its new features.

@decentral1se
Copy link
Member

decentral1se commented Mar 30, 2017

Can be closed off now that #2995 went in (forgot to close with commit).

@mgsloan
Copy link
Contributor

mgsloan commented Mar 31, 2017

Indeed! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants