Address "WARNING :: Failed to get_static_lib_exports(*.a)" by mbargull · Pull Request #4221 · conda/conda-build

mbargull · 2021-04-19T12:35:13Z

Currently, conda-build prints out WARNING :: Failed to get_static_lib_exports(*.a) whenever static libraries are using in the builds.
This is because of a mismatched type of lief.*.parse(raw=...) (explicitly needs List[int] rather than bytes).
When the parameter type is fixed, it fails because lief.Binary.exported_functions gives an iterable of lief.Function objects (or just names, i.e., strs, in older versions) which do not have .exported/.imported members.

I can't say with any confidence, I know what I'm doing here because I did not dig in too deep of LIEF, the surrounding code and everything. Silver lining: If the changed code now raises another exception, the behavior would be identical because the previous one always failed (and the exception is caught and replaced the the mentioned warning). The unknown for me is just in case no exception is raised, IDK what difference a non-empty list of returned "imported by not exported" symbols affects.

mbargull · 2021-04-19T12:39:46Z

                # print(syms_b)
            else:
-                obj = lief.ELF.parse(raw=content[obj_start:obj_end])
+                obj = lief.ELF.parse(raw=list(content[obj_start:obj_end]))


lief.parse accepts raw: bytes or raw: List[int], but lief.*.parse only accepts raw: List[int].

mbargull · 2021-04-19T12:42:57Z

+    imported_function_names = set()
    if len(binary.exported_functions):
        syms = binary.exported_functions
+        imported_function_names = {s.name for s in binary.imported_functions}


I don't really know if this is the correct thing to do. Just made sense given the names of lief.Binary's members.

mbargull · 2021-04-19T12:46:07Z

            pass
    res = []
+    imported_function_names = set()
    if len(binary.exported_functions):


NB: Due to lack of deeper knowledge of LIEF, I have no idea what the implications are in prioritizing binary.exported_functions over binary.symbols over binary.static_symbols. So, IDK if it makes sense to use a (maybe?) smaller set of symbols from .exported_functions rather than just .symbols.

mbargull · 2021-10-04T13:04:45Z

@isuruf, @xhochy, apart from Ray, you are the ones that I know of who had a look at LIEF or related code. Could one of you take a look at this?
Of course, this is supposed to be a proper fix if possible. But personally, I'd mainly want to de-clutter conda-build's logs to better see its DSO analysis output :).

xhochy · 2022-12-20T16:00:22Z

@isuruf, @xhochy, apart from Ray, you are the ones that I know of who had a look at LIEF or related code. Could one of you take a look at this? Of course, this is supposed to be a proper fix if possible. But personally, I'd mainly want to de-clutter conda-build's logs to better see its DSO analysis output :).

I sadly don't have any expertise either that would go beyond running this code and seeing whether it passes. So I cannot add something on top of what other conda-build reviewers would do here.

github-actions · 2023-12-21T04:02:26Z

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

Rebase and verify the changes still work
Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

github-actions · 2023-12-21T04:02:28Z

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

Rebase and verify the changes still work
Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

lief.Function from the Python API does not seem to expose flags directly. Maybe lief.Binary.imported_functions can act as a counterpart to lief.Binary.exported_functions then?

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>

mbargull · 2024-03-11T16:12:13Z

pre-commit.ci autofix

for more information, see https://pre-commit.ci

mbargull · 2024-03-11T16:47:36Z

gh-4850 just disabled this code path by default without any attempted fixes.
Seeing the code in gh-5228 again reminded me of this PR and since I don't believe anything has changed since 2021, I revived it.

github-actions · 2025-03-12T04:02:53Z

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

Rebase and verify the changes still work
Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

beckermr · 2025-03-12T07:03:53Z

Not stale

github-actions · 2026-03-13T04:32:35Z

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

Rebase and verify the changes still work
Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

beckermr · 2026-03-13T10:47:24Z

not stale

anaconda-issue-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 19, 2021

mbargull added a commit to mbargull/conda-build that referenced this pull request Apr 19, 2021

Add news/condagh-4221-failed-to-get_static_lib_exports.rst

0d712d0

mbargull commented Apr 19, 2021

View reviewed changes

mbargull added a commit to mbargull/conda-build that referenced this pull request Apr 19, 2021

Add news/condagh-4221-failed-to-get_static_lib_exports.rst

ee24322

mbargull force-pushed the failed-to-get_static_lib_exports branch from 0d712d0 to ee24322 Compare April 19, 2021 12:41

mbargull commented Apr 19, 2021

View reviewed changes

mbargull marked this pull request as ready for review April 19, 2021 13:00

mbargull closed this Jun 1, 2021

mbargull reopened this Jun 1, 2021

mbargull added a commit to mbargull/conda-build that referenced this pull request Jun 1, 2021

Add news/condagh-4221-failed-to-get_static_lib_exports.rst

0d91589

mbargull force-pushed the failed-to-get_static_lib_exports branch from ee24322 to 0d91589 Compare June 1, 2021 11:18

mbargull added a commit to mbargull/conda-build that referenced this pull request Oct 4, 2021

Add news/condagh-4221-failed-to-get_static_lib_exports.rst

a964af9

mbargull force-pushed the failed-to-get_static_lib_exports branch from 0d91589 to a964af9 Compare October 4, 2021 09:59

github-actions bot added the stale [bot] marked as stale due to inactivity label Dec 21, 2023

github-actions bot added the stale::closed [bot] closed after being marked as stale label Jan 21, 2024

github-actions bot closed this Jan 21, 2024

mbargull added 4 commits March 11, 2024 17:04

liefldd: Use List[int] not bytes for lief.*.parse

36287e8

liefldd: lief.Function has no .exported/.imported

422f736

lief.Function from the Python API does not seem to expose flags directly. Maybe lief.Binary.imported_functions can act as a counterpart to lief.Binary.exported_functions then?

Add news/condagh-4221-failed-to-get_static_lib_exports.rst

8168c74

Update news/4221-failed-to-get_static_lib_exports

e828b60

Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>

mbargull reopened this Mar 11, 2024

mbargull requested a review from a team as a code owner March 11, 2024 16:10

mbargull removed stale [bot] marked as stale due to inactivity stale::closed [bot] closed after being marked as stale labels Mar 11, 2024

mbargull force-pushed the failed-to-get_static_lib_exports branch from a964af9 to e828b60 Compare March 11, 2024 16:11

[pre-commit.ci] auto fixes from pre-commit.com hooks

73fb2a7

for more information, see https://pre-commit.ci

github-actions bot added the stale [bot] marked as stale due to inactivity label Mar 12, 2025

beckermr removed the stale [bot] marked as stale due to inactivity label Mar 12, 2025

github-actions bot added the stale [bot] marked as stale due to inactivity label Mar 13, 2026

beckermr removed the stale [bot] marked as stale due to inactivity label Mar 13, 2026

Conversation

mbargull commented Apr 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbargull Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

mbargull Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

mbargull Apr 19, 2021

Choose a reason for hiding this comment

Uh oh!

mbargull commented Oct 4, 2021

Uh oh!

xhochy commented Dec 20, 2022

Uh oh!

github-actions bot commented Dec 21, 2023

Uh oh!

github-actions bot commented Dec 21, 2023

Uh oh!

mbargull commented Mar 11, 2024

Uh oh!

mbargull commented Mar 11, 2024

Uh oh!

github-actions bot commented Mar 12, 2025

Uh oh!

beckermr commented Mar 12, 2025

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

beckermr commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mbargull commented Apr 19, 2021 •

edited

Loading