Use $schema keys for menuinst JSON validation#5569
Merged
jaimergp merged 16 commits intoconda:mainfrom Apr 19, 2025
Merged
Conversation
conda-bot
added
the
cla-signed
Member
Author
|
@conda/builds-tools, this is ready for review! 🙏 See conda/menuinst#283 for broader context. |
jaimergp
commented
Dec 20, 2024
CodSpeed Performance ReportMerging #5569 will not alter performanceComparing Summary
|
Member
Author
|
Gentle ping, @conda/builds-tools. |
Member
Author
|
Blocked by conda/infrastructure#1082 |
jezdez
previously requested changes
Feb 27, 2025
Member
Author
|
Needs conda/schemas#62 |
Member
Author
|
We are not raising errors yet, but will have to do so in 6 months (25.11). Edited the logging statements for now. |
Member
Author
|
@jezdez, PTAL :) |
Member
Author
|
@conda/builds-tools, this is ready for review, thanks. |
beckermr
reviewed
Apr 7, 2025
beckermr
reviewed
Apr 7, 2025
beckermr
reviewed
Apr 11, 2025
beckermr
approved these changes
Apr 14, 2025
beckermr
approved these changes
Apr 14, 2025
Contributor
|
@jezdez I went ahead and dismissed your stale review since the comments were addressed. Feel free to comment again on this PR, but it is an LGTM from me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent changes in menuinst fixed this design issue. We can now safely rely on
$schemato self-validate the JSON document. As a result,menuinstis no longer necessary as a dependency either.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?