Conversation
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @bernt-matthias. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1114), and ping the bot to refresh the PR. |
followup on conda#5595 fixes conda#5626 in lief 0.15 not only the classes were renamed but also enum members: lief-project/LIEF@cddd8dd#diff-88d5303887e96766711bd8ff242b652c29bc0ee0fa3ef8004bfc797c9a23040b latest version here: https://github.com/lief-project/LIEF/blob/0e5db4ea906b3252653dd90c627f8462d7e39ba4/api/python/lief/ELF/__init__.pyi#L2037
bernt-matthias
force-pushed
the
fix-lief-elf
branch
from
a27e21e to
477adee
Compare
| except AttributeError: | ||
| # Fallback for lief<0.15. | ||
| ELF_CLASS = lief.ELF.ELF_CLASS | ||
| ELF64 = lief.ELF.ELF64 |
There was a problem hiding this comment.
the ELF64 name wasn't used in lief prior to 0.15, was it? should this line be
ELF64 = lief.ELF.ELF_CLASS.CLASS64 ?
There was a problem hiding this comment.
Indeed. Copy paste / search replace error :)
|
@conda-bot check |
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5627 will not alter performanceComparing Summary
|
|
Anything I can do here? |
|
@bernt-matthias I was wondering what @briantoby meant with #5626 (comment), can you clarify if this works with conda-build 25.1.2? |
To specify a bit more detail, a linux packaging build that previously failed with the error in #5626 (that I addressed a few days ago by reverting to an older conda-build), now succeeds with conda-build 25.1.2, which is now pulling in an older version of liblief. FWIW, as of yesterday the older conda-build package is no longer available with Python 3.13 (or perhaps it was 3.12). HTH. |
|
@kenodegard we should probably get this one in for the next release. |
|
this is blocked by #5637 |
8 participants
Description
followup on #5595 fixes #5626
targeted 25.1.x because #5595 seems not yet merged to main
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?