rename feature ser-proto -> protobuf and expose in facade crate

Author: alecmocatta

Cargo.toml

@@ -30,6 +30,7 @@ parquet = ["amadeus-parquet", "amadeus-derive/parquet"]
 postgres = ["amadeus-postgres", "amadeus-derive/postgres"]
 csv = ["amadeus-serde", "amadeus-derive/serde"]
 json = ["amadeus-serde", "amadeus-derive/serde"]
+protobuf = ["amadeus-streaming/protobuf"]
 bench = ["serde-csv", "once_cell", "arrow-parquet", "rayon"]
 
 [package.metadata.docs.rs]

amadeus-streaming/Cargo.toml

@@ -20,11 +20,10 @@ maintenance = { status = "actively-developed" }
 
 [features]
 nightly = ["packed_simd"]
-ser-proto = ["protobuf"]
 
 [dependencies]
 packed_simd = { version = "0.3", features = ["into_bits"], optional = true }
-protobuf = { version="2.22.1", optional = true }
+protobuf = { version = "2.22", optional = true }
 rand = { version = "0.7", features = ["small_rng"] }
 serde = { version = "1.0", features = ["derive"] }
 serde_closure = "0.3"

amadeus-streaming/src/distinct.rs

@@ -44,9 +44,9 @@
 // https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.rdd.RDD countApproxDistinct
 // is_x86_feature_detected ?
 
-#[cfg(feature = "ser-proto")]
+#[cfg(feature = "protobuf")]
 use crate::proto_util;
-#[cfg(feature = "ser-proto")]
+#[cfg(feature = "protobuf")]
 use protobuf::CodedOutputStream;
 
 use serde::{Deserialize, Serialize};
@@ -343,7 +343,7 @@ where
 	/// to understand how to store and use the sketches generated by this function.
 	/// Note: this serialization  function doesn't support the sparse format as defined in Zetasketch mostly because
 	/// this HyperLogLogPlusPlus implementation doesn't support it.
-	#[cfg(feature = "ser-proto")]
+	#[cfg(feature = "protobuf")]
 	pub fn serialize_as_proto(&self) -> Vec<u8> {
 		let mut buf = Vec::new();
 		let mut stream = CodedOutputStream::new(&mut buf);
@@ -396,7 +396,7 @@ where
 		buf
 	}
 
-	#[cfg(feature = "ser-proto")]
+	#[cfg(feature = "protobuf")]
 	fn serialized_hll_size(&self) -> usize {
 		let mut size = 0_usize;
 
@@ -729,7 +729,7 @@ mod test {
 	}
 
 	#[test]
-	#[cfg(feature = "ser-proto")]
+	#[cfg(feature = "protobuf")]
 	fn hyperloglog_test_proto() {
 		let p = 0.05;
 		let mut hll = HyperLogLog::new(p);

amadeus-streaming/src/lib.rs

@@ -65,7 +65,7 @@ mod sort;
 mod top;
 mod traits;
 
-#[cfg(feature = "ser-proto")]
+#[cfg(feature = "protobuf")]
 mod proto_util;
 
 pub use count_min::*;