Skip to content

spec: ValidateVolumeCapabilities has incorrect error codes #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akutz opened this issue Nov 2, 2017 · 1 comment
Closed

spec: ValidateVolumeCapabilities has incorrect error codes #136

akutz opened this issue Nov 2, 2017 · 1 comment

Comments

@akutz
Copy link
Contributor

akutz commented Nov 2, 2017

The RPC ValidateVolumeCapabilities was updated to accept a volume ID string (765a1a5) and volume attributes map (00095b2) instead of a VolumeInfo object. However, the RPC's error codes still includes the following:

      // Indicates that the specified `VolumeInfo` is not allowed or
      // understood by the Plugin. More human-readable information MAY
      // be provided in the `error_description` field.
      //
      // Recovery behavior: Caller MUST fix the `VolumeInfo` before
      // retrying.
      INVALID_VOLUME_INFO = 5;

Instead the RPC's error codes should refactor INVALID_VOLUME_INFO into INVALID_VOLUME_ID:

      // Indicates that the specified volume ID is not allowed or
      // understood by the Plugin. More human-readable information MAY
      // be provided in the `error_description` field.
      //
      // Recovery behavior: Caller MUST fix the volume ID before
      // retrying.
      INVALID_VOLUME_ID = 5;
@jdef
Copy link
Member

jdef commented Dec 19, 2017

resolved by #115. please re-open if needed

@jdef jdef closed this as completed Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants