Skip to content

NodePublishVolumeRequest() should define what to do as a driver when given a targetPath for a block volume #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpabon opened this issue Oct 31, 2018 · 3 comments
Assignees
Milestone

Comments

@lpabon
Copy link

lpabon commented Oct 31, 2018

NodePublishVolumeRequest() should define what to do as a driver when given a targetPath for a block volume. Right now in Kubernetes-csi we are assuming it is the responsibility of the CO to create the directory where the Symlink will live, for the CO to pass the targetPath (which is the symlink name) and for the CO to create the symlink to the raw device node.

See #285

@saad-ali saad-ali added this to the v1.0 milestone Oct 31, 2018
@jieyu
Copy link
Member

jieyu commented Oct 31, 2018

We need to make it clear in the spec that who (CO or SP) is responsible for creating the target_path, and the target_path will be a file for block device and a directory for volume.

@saad-ali saad-ali self-assigned this Nov 6, 2018
@jieyu
Copy link
Member

jieyu commented Nov 7, 2018

This is related to #80

@saad-ali
Copy link
Member

saad-ali commented Mar 6, 2019

Resolved in #335

@saad-ali saad-ali closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants