Skip to content

Commit e539199

Browse files
committed
add buildfilter test
1 parent f309ad4 commit e539199

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

pkg/filters/filters_test.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,26 @@ func TestFilterByNoneScope(t *testing.T) {
138138
container.AssertExpectations(t)
139139
}
140140

141+
func TestBuildFilterNoneScope(t *testing.T) {
142+
filter, desc := BuildFilter(nil, nil, false, "none")
143+
144+
assert.Contains(t, desc, "without a scope")
145+
146+
scoped := new(mocks.FilterableContainer)
147+
scoped.On("Enabled").Return(false, false)
148+
scoped.On("Scope").Return("anyscope", true)
149+
150+
unscoped := new(mocks.FilterableContainer)
151+
unscoped.On("Enabled").Return(false, false)
152+
unscoped.On("Scope").Return("", false)
153+
154+
assert.False(t, filter(scoped))
155+
assert.True(t, filter(unscoped))
156+
157+
scoped.AssertExpectations(t)
158+
unscoped.AssertExpectations(t)
159+
}
160+
141161
func TestFilterByDisabledLabel(t *testing.T) {
142162
filter := FilterByDisabledLabel(NoFilter)
143163
assert.NotNil(t, filter)

0 commit comments

Comments
 (0)