Add the missing JSON_THROW_ON_ERROR flags

Author: leofeyer

src/Routing/ResponseContext/JsonLd/JsonLdManager.php

@@ -67,7 +67,7 @@ public function collectFinalScriptFromGraphs(): string
 
         ArrayUtil::recursiveKeySort($data);
 
-        return '<script type="application/ld+json">'."\n".json_encode($data, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE)."\n".'</script>';
+        return '<script type="application/ld+json">'."\n".json_encode($data, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_THROW_ON_ERROR)."\n".'</script>';
     }
 
     /**

tests/Controller/BackendPreviewSwitchControllerTest.php

@@ -242,7 +242,7 @@ public function testReturnsEmptyMemberList(): void
 
         $this->assertInstanceOf(JsonResponse::class, $response);
         $this->assertSame(Response::HTTP_OK, $response->getStatusCode());
-        $this->assertSame(json_encode([]), $response->getContent());
+        $this->assertSame(json_encode([], JSON_THROW_ON_ERROR), $response->getContent());
     }
 
     public function testExitsAsUnauthenticatedUser(): void

tests/Monolog/ContaoContextTest.php

@@ -38,14 +38,17 @@ public function testSupportsReadingAndWritingValues(): void
         $context->setUri('https://www.contao.org');
         $context->setPageId(42);
 
-        $json = json_encode([
-            'func' => 'foo',
-            'action' => 'action',
-            'username' => 'username',
-            'browser' => 'Mozilla',
-            'uri' => 'https://www.contao.org',
-            'pageId' => 42,
-        ]);
+        $json = json_encode(
+            [
+                'func' => 'foo',
+                'action' => 'action',
+                'username' => 'username',
+                'browser' => 'Mozilla',
+                'uri' => 'https://www.contao.org',
+                'pageId' => 42,
+            ],
+            JSON_THROW_ON_ERROR
+        );
 
         $this->assertSame($json, (string) $context);
     }

tests/Picker/ArticlePickerProviderTest.php

@@ -43,12 +43,15 @@ protected function tearDown(): void
 
     public function testCreatesTheMenuItem(): void
     {
-        $config = json_encode([
-            'context' => 'link',
-            'extras' => [],
-            'current' => 'articlePicker',
-            'value' => '',
-        ]);
+        $config = json_encode(
+            [
+                'context' => 'link',
+                'extras' => [],
+                'current' => 'articlePicker',
+                'value' => '',
+            ],
+            JSON_THROW_ON_ERROR
+        );
 
         if (\function_exists('gzencode') && false !== ($encoded = @gzencode($config))) {
             $config = $encoded;

tests/Picker/FilePickerProviderTest.php

@@ -28,12 +28,15 @@ class FilePickerProviderTest extends TestCase
 {
     public function testCreatesTheMenuItem(): void
     {
-        $config = json_encode([
-            'context' => 'link',
-            'extras' => [],
-            'current' => 'filePicker',
-            'value' => '',
-        ]);
+        $config = json_encode(
+            [
+                'context' => 'link',
+                'extras' => [],
+                'current' => 'filePicker',
+                'value' => '',
+            ],
+            JSON_THROW_ON_ERROR
+        );
 
         if (\function_exists('gzencode') && false !== ($encoded = @gzencode($config))) {
             $config = $encoded;

tests/Picker/PagePickerProviderTest.php

@@ -26,12 +26,15 @@ class PagePickerProviderTest extends ContaoTestCase
 {
     public function testCreatesTheMenuItem(): void
     {
-        $config = json_encode([
-            'context' => 'link',
-            'extras' => [],
-            'current' => 'pagePicker',
-            'value' => '',
-        ]);
+        $config = json_encode(
+            [
+                'context' => 'link',
+                'extras' => [],
+                'current' => 'pagePicker',
+                'value' => '',
+            ],
+            JSON_THROW_ON_ERROR
+        );
 
         if (\function_exists('gzencode') && false !== ($encoded = @gzencode($config))) {
             $config = $encoded;

tests/Picker/PickerConfigTest.php

@@ -79,12 +79,15 @@ public function testSerializesItselfToAnArray(): void
 
     public function testCreatesAnEncodedJsonString(): void
     {
-        $data = json_encode([
-            'context' => 'link',
-            'extras' => ['fieldType' => 'radio'],
-            'current' => 'alias',
-            'value' => 'foo',
-        ]);
+        $data = json_encode(
+            [
+                'context' => 'link',
+                'extras' => ['fieldType' => 'radio'],
+                'current' => 'alias',
+                'value' => 'foo',
+            ],
+            JSON_THROW_ON_ERROR
+        );
 
         if (\function_exists('gzencode') && false !== ($encoded = @gzencode($data))) {
             $data = $encoded;
@@ -95,12 +98,15 @@ public function testCreatesAnEncodedJsonString(): void
 
     public function testDecodesAnEncodedJsonString(): void
     {
-        $data = json_encode([
-            'context' => 'link',
-            'extras' => ['fieldType' => 'radio'],
-            'current' => 'alias',
-            'value' => 'foo',
-        ]);
+        $data = json_encode(
+            [
+                'context' => 'link',
+                'extras' => ['fieldType' => 'radio'],
+                'current' => 'alias',
+                'value' => 'foo',
+            ],
+            JSON_THROW_ON_ERROR
+        );
 
         if (\function_exists('gzencode') && false !== ($encoded = @gzencode($data))) {
             $data = $encoded;

tests/Security/TwoFactor/BackupCodeManagerTest.php

@@ -82,10 +82,13 @@ public function testHandlesContaoUsers(): void
 
     public function testInvalidatesBackupCode(): void
     {
-        $backupCodes = json_encode([
-            '$2y$10$vY0fVrqfUmzzHSQpT6ZMPOGwrYLq.9s/Y1M9cV9/0K0SlGH/kMotC', // 4ead45-4ea70a
-            '$2y$10$Ie2VHgQLiNTfAI1kDV19U.i9dsvIE4tt3h75rpVHnoWqJFS0Lq1Yy', // 0082ec-b95f03
-        ]);
+        $backupCodes = json_encode(
+            [
+                '$2y$10$vY0fVrqfUmzzHSQpT6ZMPOGwrYLq.9s/Y1M9cV9/0K0SlGH/kMotC', // 4ead45-4ea70a
+                '$2y$10$Ie2VHgQLiNTfAI1kDV19U.i9dsvIE4tt3h75rpVHnoWqJFS0Lq1Yy', // 0082ec-b95f03
+            ],
+            JSON_THROW_ON_ERROR
+        );
 
         $user = $this->mockClassWithProperties(BackendUser::class);
         $user->backupCodes = $backupCodes;