Migrates golangci-lint to v2 (#1445)

* add some linters, make linter happy again

* remove comments

* fix

* nit

Author: M4tteoP

.golangci.yml

@@ -1,22 +1,23 @@
-run:
-  deadline: 5m
-
+version: "2"
+timeout: 5m
 linters:
-  disable-all: true
+  default: none
   enable:
-    # Enabled by default, see https://golangci-lint.run/usage/linters#enabled-by-default
     - errcheck
-    - gosimple
+    - errname
+    - gocritic
     - govet
     - ineffassign
     - staticcheck
-    - typecheck
     - unused
-    - goimports
+    - misspell
+  exclusions:
+    generated: lax
+    presets:
+      - common-false-positives
+      - std-error-handling
+formatters:
+  enable:
     - gofmt
-    - gocritic
-issues:
-  exclude-rules:
-    - path: magefile\.go
-      linters:
-        - deadcode
+    - goimports
+    

experimental/plugins/auditlog_formatter_test.go

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 //go:build !tinygo
-// +build !tinygo
 
 // Not aimed to tinygo as serial writer is a noop writer
 

experimental/plugins/auditlog_formatter_tinygo_test.go

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 //go:build tinygo
-// +build tinygo
 
 // Aimed to tinygo, initializing a dedicated serial writer
 package plugins_test

experimental/plugins/auditlog_writer_test.go

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 //go:build !tinygo
-// +build !tinygo
 
 package plugins_test
 

experimental/plugins/plugintypes/auditlog.go

@@ -64,7 +64,7 @@ type AuditLogTransactionRequest interface {
 	Headers() map[string][]string
 	Body() string
 	Files() []AuditLogTransactionRequestFiles
-	Args() *collections.ConcatKeyed // A string representation of all request agruments in the format 'k=v,'
+	Args() *collections.ConcatKeyed // A string representation of all request arguments in the format 'k=v,'
 	Length() int32                  // The total size of the request in bytes
 }
 

http/e2e/cmd/httpe2e/main.go

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 //go:build !tinygo
-// +build !tinygo
 
 package main
 

http/e2e/e2e.go

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 //go:build !tinygo
-// +build !tinygo
 
 package e2e
 
@@ -274,7 +273,7 @@ func Run(cfg Config) error {
 			timeout--
 			if timeout == 0 {
 				if err != nil {
-					return fmt.Errorf("timeout waiting for response from %s, make sure the server is running. Last request error: %v", healthCheck.url, err)
+					return fmt.Errorf("timeout waiting for response from %s, make sure the server is running. Last request error: %w", healthCheck.url, err)
 				}
 
 				return fmt.Errorf("timeout waiting for response from %s, unexpected status code", healthCheck.url)

http/e2e/e2e_test.go

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: Apache-2.0
 
 //go:build !tinygo
-// +build !tinygo
 
 package e2e
 

http/interceptor.go

@@ -3,7 +3,6 @@
 
 // tinygo does not support net.http so this package is not needed for it
 //go:build !tinygo
-// +build !tinygo
 
 package http
 
@@ -77,7 +76,7 @@ func (i *rwInterceptor) cleanHeaders() {
 // interruption is triggered, this buffer is later used to analyse the body in
 // the response processor.
 // If the body isn't accessible or the mime type isn't processable, the response
-// body is being writen to the delegate response writer directly.
+// body is being written to the delegate response writer directly.
 func (i *rwInterceptor) Write(b []byte) (int, error) {
 	if i.tx.IsInterrupted() {
 		// if there is an interruption it must be from at least phase 4 and hence
@@ -184,15 +183,15 @@ func wrap(w http.ResponseWriter, r *http.Request, tx types.Transaction) (
 			if err != nil {
 				i.overrideWriteHeader(http.StatusInternalServerError)
 				i.flushWriteHeader()
-				return fmt.Errorf("failed to release the response body reader: %v", err)
+				return fmt.Errorf("failed to release the response body reader: %w", err)
 			}
 
 			// this is the last opportunity we have to report the resolved status code
 			// as next step is write into the response writer (triggering a 200 in the
 			// response status code.)
 			i.flushWriteHeader()
 			if _, err := io.Copy(w, reader); err != nil {
-				return fmt.Errorf("failed to copy the response body: %v", err)
+				return fmt.Errorf("failed to copy the response body: %w", err)
 			}
 		} else {
 			i.flushWriteHeader()

http/interceptor_test.go

@@ -3,7 +3,6 @@
 
 // tinygo does not support net.http so this package is not needed for it
 //go:build !tinygo
-// +build !tinygo
 
 package http