Rename method to getFreshGEQ

Author: john-h-kastner

clang/include/clang/CConv/Constraints.h

@@ -592,9 +592,10 @@ class Constraints {
                  PersistentSourceLoc *PL, bool isCheckedConstraint = true);
   Implies *createImplies(Geq *Premise, Geq *Conclusion);
 
-  VarAtom * getVarGEQ(std::string Name, VarAtom::VarKind VK, ConstAtom *Con,
-            std::string Rsn = DEFAULT_REASON,
-            PersistentSourceLoc *PSL = nullptr);
+  VarAtom *createFreshGEQ(std::string Name, VarAtom::VarKind VK, ConstAtom *Con,
+                          std::string Rsn = DEFAULT_REASON,
+                          PersistentSourceLoc *PSL = nullptr);
+
   VarAtom *getFreshVar(std::string Name, VarAtom::VarKind VK);
   VarAtom *getOrCreateVar(ConstraintKey V, std::string Name,
                           VarAtom::VarKind VK);

clang/lib/CConv/ConstraintVariables.cpp

@@ -46,8 +46,8 @@ PointerVariableConstraint *
 PointerVariableConstraint::getWildPVConstraint(Constraints &CS,
                                                const std::string &Rsn,
                                                PersistentSourceLoc *PSL) {
-  VarAtom *VA = CS.getVarGEQ("wildvar", VarAtom::V_Other,
-                             CS.getWild(), Rsn, PSL);
+  VarAtom *VA = CS.createFreshGEQ("wildvar", VarAtom::V_Other,
+                                  CS.getWild(), Rsn, PSL);
   CAtoms NewAtoms = {VA};
   PVConstraint *WildPVC = new PVConstraint(NewAtoms, "unsigned", "wildvar",
                                            nullptr, false, false, "");
@@ -230,7 +230,7 @@ PointerVariableConstraint::PointerVariableConstraint(const QualType &QT,
     if (isVarArgType(TyName)) {
       // Variable number of arguments. Make it WILD.
       std::string Rsn = "Variable number of arguments.";
-      VarAtom *WildVA = CS.getVarGEQ(Npre + N, VK, CS.getWild(), Rsn);
+      VarAtom *WildVA = CS.createFreshGEQ(Npre + N, VK, CS.getWild(), Rsn);
       vars.push_back(WildVA);
       VarCreated = true;
       break;

clang/lib/CConv/Constraints.cpp

@@ -581,9 +581,9 @@ VarAtom *Constraints::getVar(ConstraintKey V) const {
 // Constructs a fresh VarAtom constrained GEQ the specified constant atom. This
 // should generally be used instead of using constant atoms directly if the the
 // VarAtom will be used in the variables vector of a PVConstraint.
-VarAtom *Constraints::getVarGEQ(std::string Name, VarAtom::VarKind VK,
-                                ConstAtom *Con, std::string Rsn,
-                                PersistentSourceLoc *PSL) {
+VarAtom *Constraints::createFreshGEQ(std::string Name, VarAtom::VarKind VK,
+                                     ConstAtom *Con, std::string Rsn,
+                                     PersistentSourceLoc *PSL) {
   VarAtom *VA = getFreshVar(Name, VK);
   addConstraint(createGeq(VA, Con, Rsn, PSL));
   return VA;