Handling comments

Author: Machiry

clang/include/clang/CConv/ConstraintsGraph.h

@@ -167,7 +167,6 @@ class DataGraph :
     // Insert into BFS cache.
     if (BFSCache.find(Start) == BFSCache.end()) {
       std::set<Data> ReachableNodes;
-      ReachableNodes.clear();
       for (auto TNode : llvm::breadth_first(*N)) {
         ReachableNodes.insert(TNode->getData());
       }

clang/test/CheckedCRewriter/arrboundsmerging.c

@@ -27,6 +27,11 @@ void foo3(int *x, int c) {
   x[0] = c;
 }
 
+void foo4(int *x, int c) {
+//CHECK: void foo4(_Array_ptr<int> x, int c) {
+  x[0] = c;
+}
+
 void bar(void) {
   int *p = malloc(sizeof(int)*8);
   int *q = malloc(sizeof(int)*8);
@@ -38,18 +43,27 @@ void bar(void) {
 //CHECK: _Array_ptr<int> q1 : count(8) = malloc<int>(sizeof(int)*8);
 
   int n = 8;
-  int l;
+  int l = 4;
   int *q2 = malloc(sizeof(int)*l);
+  int *q4 = malloc(sizeof(int)*n);
 
   // Variation 1
+  // Correct size association: second argument is indeed the size.
   foo(p,n);
   foo(q,8);
 
   // Variation 2
+  // passing fixed size array: No size association.
   foo2(p1,8);
   foo2(q1,28);
 
   // Variation 3
+  // Variable sized arrays: One correct and one wrong bounds.
   foo3(q2,l);
   foo3(q1,28);
+
+  // Variation 4
+  // Passing wrong lengths to check bounds.
+  foo4(q2,n);
+  foo4(q4,l);
 }