Skip to content

Create pull request for branch dev-fixes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Machiry opened this issue Jul 26, 2019 · 5 comments
Closed

Create pull request for branch dev-fixes #10

Machiry opened this issue Jul 26, 2019 · 5 comments
Assignees
Labels
Upstream Work item that has to deal with making changes to upstream.

Comments

@Machiry
Copy link
Collaborator

Machiry commented Jul 26, 2019

This fixes various issues on top of the dev branch.
Specifically, the following issues have been fixed:

@rchyena
Copy link

rchyena commented Jul 26, 2019

I will look over this PR, but you have push access to the repository, right? You should just merge stuff when you feel like it's ready.

@rchyena
Copy link

rchyena commented Jul 26, 2019

Oh, wait. Did you mean raise a pull request on microsoft/checkedc-clang repo?

@Machiry
Copy link
Collaborator Author

Machiry commented Jul 27, 2019

Yes. When our main dev gets merged. We can raise PR for this. Should we first merge this into our dev?

@rchyena
Copy link

rchyena commented Jul 27, 2019

Yes. You should merge dev-fixes into dev. Once Microsoft accepts PR #642, we will merge their master into dev, and we can raise a new PR.

@Machiry Machiry added the Upstream Work item that has to deal with making changes to upstream. label Aug 12, 2019
@Machiry
Copy link
Collaborator Author

Machiry commented Sep 4, 2019

Raised the pull request.

@Machiry Machiry closed this as completed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream Work item that has to deal with making changes to upstream.
Projects
None yet
Development

No branches or pull requests

2 participants