Skip to content

Verify fix for bogus reports of line ending changes in a clean git checkout #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattmccutchen-cci opened this issue Nov 3, 2020 · 1 comment · Fixed by #438
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@mattmccutchen-cci
Copy link
Member

mattmccutchen-cci commented Nov 3, 2020

Sometimes, git shows source files in a clean checkout as having modified line endings, even if you only ever use Linux. The problem seems to occur less often with newer versions of git. We believe the root cause is that the root .gitattributes file inaccurately states that all files have LF endings, but some have CRLF endings in the repository. We should fix this in Microsoft's or even LLVM's repository if possible, or otherwise in ours after it diverges from Microsoft (#302).

@mattmccutchen-cci
Copy link
Member Author

This problem was only ever at the Microsoft level, not LLVM. Microsoft has recently merged checkedc#950, which I fully expect to fix it, but I want to do some more testing before I update our documentation.

@kyleheadley kyleheadley added the documentation Improvements or additions to documentation label Dec 8, 2020
@mattmccutchen-cci mattmccutchen-cci changed the title Fix bogus reports of line ending changes in a clean git checkout Verify fix for bogus reports of line ending changes in a clean git checkout Dec 8, 2020
@mattmccutchen-cci mattmccutchen-cci linked a pull request Feb 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants