Change test7 in functionDeclEnd.c to infer a valid bound#684
Merged
Conversation
The purpose of this function was to test function declaration rewriting for itype array pointers declared with bounds but without an explicit itype. This is equally well tested when a correct bound is inferred for the parameter array.
aaronjeline
approved these changes
Aug 18, 2021
aaronjeline
left a comment
aaronjeline
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine and all tests pass
Member
|
Ideally we should also test in combination with checkedc#1150 to make sure we achieved the original goal. I've just done that now, and the test passed as expected. I'll let Microsoft know that they can cherry-pick this change if they like, but I see no harm in merging it to our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #682.
The purpose of this function was to test function declaration rewriting
for itype array pointers declared with bounds but without an explicit
itype. This is equally well tested when a correct bound is inferred for
the parameter array.
This could probably be done a few other ways. What's important though
is that there is still a bound on the return without an itype expression,
and that that the function declaration is rewritten with and without
-alltypes.