Squashed 'tools/' changes from 1fe184f..ccc8316

ccc8316 Revert "Gocyclo should return error code if issues detected" (#124)

git-subtree-dir: tools
git-subtree-split: ccc831682b5d51e068b17fe9ad482f025abd1fbb

Author: jml

lint

@@ -94,11 +94,9 @@ lint_go() {
     # don't have it installed.  Also never blocks a commit,
     # it just warns.
     if type gocyclo >/dev/null 2>&1; then
-        cycloutput=$(gocyclo -over 25 "${filename}")
-        if [ -n "$cycloutput" ]; then
-            lint_result=1
-            echo "${filename}": higher than 25 cyclomatic complexity - "${cycloutput}"
-        fi
+        gocyclo -over 25 "${filename}" | while read -r line; do
+            echo "${filename}": higher than 25 cyclomatic complexity - "${line}"
+        done
     fi
 
     return $lint_result