Skip to content

Commit 2979e3f

Browse files
committed
fix label cardinality of lifecycler metrics
Signed-off-by: Jacob Lisi <[email protected]>
1 parent 305232e commit 2979e3f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/ring/lifecycler.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -470,17 +470,17 @@ func (i *Lifecycler) processShutdown(ctx context.Context) {
470470
transferStart := time.Now()
471471
if err := i.flushTransferer.TransferOut(ctx); err != nil {
472472
level.Error(util.Logger).Log("msg", "Failed to transfer chunks to another ingester", "err", err)
473-
shutdownDuration.WithLabelValues("transfer", "fail").Observe(time.Since(transferStart).Seconds())
473+
shutdownDuration.WithLabelValues("transfer", "fail", i.RingName).Observe(time.Since(transferStart).Seconds())
474474
} else {
475475
flushRequired = false
476-
shutdownDuration.WithLabelValues("transfer", "success").Observe(time.Since(transferStart).Seconds())
476+
shutdownDuration.WithLabelValues("transfer", "success", i.RingName).Observe(time.Since(transferStart).Seconds())
477477
}
478478
}
479479

480480
if flushRequired {
481481
flushStart := time.Now()
482482
i.flushTransferer.Flush()
483-
shutdownDuration.WithLabelValues("flush", "success").Observe(time.Since(flushStart).Seconds())
483+
shutdownDuration.WithLabelValues("flush", "success", i.RingName).Observe(time.Since(flushStart).Seconds())
484484
}
485485

486486
// Sleep so the shutdownDuration metric can be collected.

0 commit comments

Comments
 (0)